Properly test batch and batch_bool constructors

Fix #103

Author: serge-sans-paille

test/test_batch.cpp

@@ -73,8 +73,35 @@ struct batch_test
         CHECK_EQ(ares, rhs);
     }
 
+    template <size_t... Is>
+    struct pack
+    {
+    };
+
+    template <size_t... Values>
+    void check_constructor_from_sequence(std::integral_constant<size_t, 0>, pack<Values...>) const
+    {
+        array_type tmp = { static_cast<value_type>(Values)... };
+        batch_type b0(static_cast<value_type>(Values)...);
+        INFO("batch(values...)");
+        CHECK_EQ(b0, tmp);
+
+        batch_type b1 { static_cast<value_type>(Values)... };
+        INFO("batch{values...}");
+        CHECK_EQ(b0, tmp);
+    }
+
+    template <size_t I, size_t... Values>
+    void check_constructor_from_sequence(std::integral_constant<size_t, I>, pack<Values...>) const
+    {
+        return check_constructor_from_sequence(std::integral_constant<size_t, I - 1>(), pack<Values..., I>());
+    }
+
     void test_constructors() const
     {
+        batch_type b;
+        // value initialized to random data, can't be checked
+
         array_type tmp;
         std::fill(tmp.begin(), tmp.end(), value_type(2));
         batch_type b0a(2);
@@ -85,9 +112,7 @@ struct batch_test
         INFO("batch{value_type}");
         CHECK_EQ(b0b, tmp);
 
-        batch_type b1 = batch_type::load_unaligned(lhs.data());
-        INFO("batch(value_type*)");
-        CHECK_EQ(b1, lhs);
+        check_constructor_from_sequence(std::integral_constant<size_t, size>(), pack<>());
     }
 
     void test_static_builders() const

test/test_batch_bool.cpp

@@ -169,16 +169,50 @@ struct batch_bool_test
         }
     }
 
+    template <size_t... Is>
+    struct pack
+    {
+    };
+
+    template <size_t... Values>
+    void check_constructor_from_sequence(std::integral_constant<size_t, 0>, pack<Values...>) const
+    {
+        bool_array_type res = { bool(Values % 3)... };
+        bool_array_type tmp;
+        batch_bool_type b0(bool(Values % 3)...);
+        b0.store_unaligned(tmp.data());
+        INFO("batch_bool(values...)");
+        CHECK_EQ(tmp, res);
+
+        batch_bool_type b1 { bool(Values % 3)... };
+        b1.store_unaligned(tmp.data());
+        INFO("batch_bool{values...}");
+        CHECK_EQ(tmp, res);
+    }
+
+    template <size_t I, size_t... Values>
+    void check_constructor_from_sequence(std::integral_constant<size_t, I>, pack<Values...>) const
+    {
+        return check_constructor_from_sequence(std::integral_constant<size_t, I - 1>(), pack<Values..., I>());
+    }
+
     void test_constructors() const
     {
+        batch_bool_type a;
+        // value uninitialized, cannot test it.
+
         bool_array_type res;
         batch_bool_type b(true);
         b.store_unaligned(res.data());
+        INFO("batch_bool{value}");
         CHECK_EQ(res, all_true);
 
         batch_bool_type c { true };
         c.store_unaligned(res.data());
+        INFO("batch_bool{value}");
         CHECK_EQ(res, all_true);
+
+        check_constructor_from_sequence(std::integral_constant<size_t, size>(), pack<>());
     }
 
     void test_load_store() const