Reorder make_batch_constant template arguments#1103
Merged
serge-sans-paille merged 1 commit intomasterfrom Mar 29, 2025
Merged
Conversation
serge-sans-paille
force-pushed
the
feature/change-make-batch-constant-api
branch
from
1c11dd2 to
1924e8d
Compare
Contributor
Author
|
@JohanMabille this is an API break |
serge-sans-paille
force-pushed
the
feature/change-make-batch-constant-api
branch
from
1924e8d to
41312c2
Compare
…uments So that we can use a default architecture, which is consistent with other API. This is an API breaking change
serge-sans-paille
force-pushed
the
feature/change-make-batch-constant-api
branch
from
41312c2 to
68a2f02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can use a default architecture, which is consistent with other API.
This is an API breaking change