Improve xsimd::expand common implementation#1200
Merged
serge-sans-paille merged 1 commit intomasterfrom Nov 12, 2025
Merged
Conversation
serge-sans-paille
force-pushed
the
feature/faster-default-expand
branch
6 times, most recently
from
ef99535 to
5adcd11
Compare
Previous implementation was making the assumption of cheap xsimd::insert, and it always generated batch::size inserts. This implementation can take advantage of smaller popcount on the bitmask. Note to self: it would be great to have a good implementation for constant mask.
serge-sans-paille
force-pushed
the
feature/faster-default-expand
branch
from
5adcd11 to
42b96a1
Compare
Contributor
|
Can you cherry pick my masks from the masked_ops? Then you have popcount for free. I will try to fix the mased memory ops in the following couple of days. |
Contributor
Author
|
@DiamonDinoia that would only be useful for constant mask, right? We currently have expand only for dynamic mask (I dislike that, I'll have to provide a generic implementation for constant mask in the future, but post-release) |
Contributor
|
Oh yes, I deleted the dynamic mask when I removed the dynamic masked ops. With rebasing the changes might be lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation was making the assumption of cheap xsimd::insert, and it always generated batch::size inserts.
This implementation can take advantage of smaller popcount on the bitmask.
Note to self: it would be great to have a good implementation for constant mask.