Improve masked load/store for sse2 when only the first element is sel…#1216
Merged
serge-sans-paille merged 1 commit intomasterfrom Nov 28, 2025
Merged
Conversation
Contributor
Author
|
cc @DiamonDinoia . It mostly helps GCC, clang is generally capable of finding the right pattern on its own. |
Contributor
|
Nice! I will review more carefully next week but I like the changes. |
serge-sans-paille
force-pushed
the
feature/improve-load-store-masked
branch
from
c130389 to
0093e62
Compare
serge-sans-paille
force-pushed
the
feature/improve-load-store-masked
branch
from
0093e62 to
d0ecc44
Compare
Contributor
Author
|
@DiamonDinoia I've rebased on top of latest changes, we're getting close to a release, I only have to implement wasm support and we're good to go (and maybe ppc too)... |
Contributor
Author
|
@DiamonDinoia gentle ping :-) |
DiamonDinoia
approved these changes
Nov 28, 2025
Contributor
DiamonDinoia
left a comment
DiamonDinoia
left a comment
There was a problem hiding this comment.
LGTM.
I was thinking of doing something like: mask.countr_one() == 1 && mask.popcount() == 1 instead of mask.mask() == 0x1 bit I think the latter is better in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ected