Publish the C++14 requirement through cmake interface#1279
Merged
serge-sans-paille merged 1 commit intomasterfrom Mar 26, 2026
Merged
Publish the C++14 requirement through cmake interface#1279serge-sans-paille merged 1 commit intomasterfrom
serge-sans-paille merged 1 commit intomasterfrom
Conversation
Contributor
|
we should also update the readme: ". In this case, you must build your project with C++14 support enabled.". c++14 must be enabled so this sentence is not needed anymore. |
Contributor
Author
|
On Thu, Mar 26, 2026 at 08:36:00AM -0700, Marco Barbone wrote:
●DiamonDinoia left a comment [1](xtensor-stack/xsimd#1279)
we should also update the readme: ". In this case, you must build your project
with C++14 support enabled.". c++14 must be enabled so this sentence is not
needed anymore.
Correct! Can you submit that patch?
|
Contributor
|
Done. I leave the review to you. Could you have a look at my other PRs once you have time? I would like to use the stream API in some projects :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.