fix: avoid per-instantiation vtable issues with MinGW GCC#1290
Merged
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom Apr 9, 2026
Merged
Conversation
| #define CHECK_BATCH_EQ(b1, b2) \ | ||
| do \ | ||
| { \ | ||
| auto _ctx1 = ::detail::make_context_info(#b1, b1); \ |
Contributor
There was a problem hiding this comment.
please add a small comment here and below to explain why we're doing something smart :-)
Replace INFO() macro calls with concrete StringContextScope class to work around MinGW GCC generating a unique vtable per template instantiation. INFO() creates ContextScope<Lambda> which triggers this issue; the concrete class has a single vtable definition shared across all instantiations. - Add StringContextScope struct inheriting from doctest::detail::ContextScopeBase - Add make_context_info() helper to create context without template lambdas - Update CHECK_BATCH_EQ, CHECK_SCALAR_EQ, CHECK_VECTOR_EQ macros to use new helper
DiamonDinoia
force-pushed
the
fix/mingw-doctest-vtable
branch
from
6d6ccbc to
00faa0d
Compare
Contributor
|
the error looks unrelated? o_O |
Contributor
Author
|
The failure seems that in test/test_shuffle.cpp:623 — a -Werror=uninitialized error in the transpose() test for batch on AVX512 with GCC 13. It's complaining about b_matrix being used uninitialized. I don't think this is related to this PR. |
serge-sans-paille
merged commit 6b61b1a
into
xtensor-stack:master
57 of 73 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace INFO() macro calls with concrete StringContextScope class to work around MinGW GCC generating a unique vtable per template instantiation. INFO() creates ContextScope which triggers this issue; the concrete class has a single vtable definition shared across all instantiations.