CMake cleanup#1305
Merged
serge-sans-paille merged 2 commits intoxtensor-stack:masterfrom Apr 16, 2026
Merged
Conversation
serge-sans-paille
approved these changes
Apr 16, 2026
|
|
||
| cmake_minimum_required(VERSION 3.10) | ||
| project(xsimd) | ||
| option(XSIMD_REFACTORING ON) |
Contributor
There was a problem hiding this comment.
XSIMD_REFACTORING, that brings back some memories :-)
| if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64" AND NOT CMAKE_OSX_ARCHITECTURES) | ||
|
|
||
| if(NOT TARGET xsimd) | ||
| find_package(xsimd REQUIRED CONFIG) |
Contributor
There was a problem hiding this comment.
that's a very neat trick, <3
Contributor
Author
There was a problem hiding this comment.
I did not make it up, it comes up frequently in CMake files :)
serge-sans-paille
merged commit 8d6d1f1
into
xtensor-stack:master
79 of 88 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.