Make test_rounding to go over all the inputs#1318
Merged
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom Apr 24, 2026
Merged
Make test_rounding to go over all the inputs#1318serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom
Conversation
Andreas-Krebbel
force-pushed
the
fix_test_round
branch
2 times, most recently
from
9780929 to
f67da32
Compare
Merged
Andreas-Krebbel
force-pushed
the
fix_test_round
branch
from
f67da32 to
95613a8
Compare
Andreas-Krebbel
force-pushed
the
fix_test_round
branch
from
95613a8 to
2f29eec
Compare
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_rounding calculates how many batches need to be run to cover all the input values in nb_batches. However, when the loops go over the number of batches, the batch count is increased by the batch size. This is probably not what was intended here.
What currently happens is that e.g. for a 128 bit float vector only the first four values are actually tested, leaving out some of the interesting ones coming later.
I've tested the change on x86 and s390x. Both are still clean.
On Power however, this reveals an oddity with the vec_round builtin on float vectors, where it uses a different rounding mode than for doubles. I'll try to address this with a separate PR.