IBM Z (s390x) fixes#1325
Merged
JohanMabille merged 1 commit intoxtensor-stack:masterfrom Apr 24, 2026
Merged
Conversation
serge-sans-paille
approved these changes
Apr 24, 2026
| -DCMAKE_TOOLCHAIN_FILE=${{ github.workspace }}/.github/toolchains/${{ matrix.sys.compiler }}-${{ matrix.target.dir }}.cmake | ||
| - name: Build | ||
| run: cmake --build _build --verbose -j1 | ||
| run: cmake --build build/ --verbose -j1 |
Contributor
There was a problem hiding this comment.
I'm curious: why this change?
Contributor
Author
There was a problem hiding this comment.
This is how cross-ppc.yml does it and I thought it would make sense to keep the two files as close as possible.
| matrix: | ||
| target: | ||
| - { platform: 's390x', dir: 's390x-linux-gnu', flags: '-mzvector -march=z14', full: 'OFF' } | ||
| - { platform: 's390x', dir: 's390x-linux-gnu', flags: '', full: 'OFF' } |
Contributor
There was a problem hiding this comment.
remove flags then? Or keep it so that we can update in one place in the future? Up to you.
Contributor
Author
There was a problem hiding this comment.
The flags have been redundant since I already had it in test/CMakeLists.txt so they appeared twice on the command line in the github workflow:
elseif(${CMAKE_SYSTEM_PROCESSOR} MATCHES "s390x")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=z14 -mzvector")
Power seems to do it the other way around.
I'll remove flags from cross-s390x.yml then I guess.
Andreas-Krebbel
force-pushed
the
s390x-fixes
branch
from
d11c1cb to
ac9a498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with GCC and Clang on IBM z17. Workflow tested locally. It runs all the tests now successfully.