Merge pull request #46 from kokarez/noexp

Allow xtensor-fftw to build with -fno-exceptions

Author: SylvainCorlay

.appveyor.yml

@@ -14,16 +14,10 @@ environment:
     - MINICONDA: C:\Miniconda36-x64
       FFTW_INSTALL_MODE: conda-forge
       FFTW_ROOT:
-    - MINICONDA: C:\Miniconda36
-      FFTW_INSTALL_MODE: conda-forge
-      FFTW_ROOT:
       # fftw from the "official" fftw website build
     - MINICONDA: C:\Miniconda36-x64
       FFTW_INSTALL_MODE: official
       FFTW_ROOT: C:\fftw_download
-    - MINICONDA: C:\Miniconda36
-      FFTW_INSTALL_MODE: official
-      FFTW_ROOT: C:\fftw_download
 
 matrix:
   exclude:
@@ -42,7 +36,7 @@ install:
   - conda config --add channels conda-forge
   - conda update -q conda
   - conda info -a
-  - conda install xtensor
+  - conda install xtensor=0.21.2 -c conda-forge
   - IF "%FFTW_INSTALL_MODE%"=="official" ( Powershell.exe -File appveyor_install_fftw.ps1 ) ELSE IF "%FFTW_INSTALL_MODE%"=="conda-forge" ( conda install fftw )
   - cd %APPVEYOR_BUILD_FOLDER%
   - mkdir build

.travis.yml

@@ -51,6 +51,15 @@ matrix:
             - g++-7
             - libfftw3-dev
       env: COMPILER=gcc GCC=7
+    - os: linux
+      addons:
+        apt:
+          sources:
+            - ubuntu-toolchain-r-test
+          packages:
+            - g++-7
+            - libfftw3-dev
+      env: COMPILER=gcc GCC=7 DISABLE_EXCEPTION=1
     - os: linux
       addons:
         apt:
@@ -148,7 +157,7 @@ install:
     - export PATH="$HOME/miniconda/bin:$PATH"
     - hash -r
     - conda update -yq conda
-    - conda install -y cmake xtl==0.6.7 xtensor=0.20.10 nlohmann_json=3.7.1 -c conda-forge
+    - conda install -y cmake xtl==0.6.9 xtensor=0.21.2 nlohmann_json=3.7.1 -c conda-forge
     - |
       if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
         conda install -y fftw -c conda-forge

CMakeLists.txt

@@ -45,6 +45,7 @@ OPTION(BENCHMARK_ENABLE_TESTING "Build tests for Google Benchmark" OFF)
 OPTION(FIX_RPATH "Correctly set rpath for the linker" OFF)
 OPTION(DEFAULT_COLUMN_MAJOR "Set xtensor default layout to column major. This is currently not supported, since FFTW demands row major layout." OFF)
 OPTION(COVERAGE "Enable coverage compile flags (gcc only!)" OFF)
+OPTION(DISABLE_EXCEPTIONS "Disable C++ exceptions" OFF)
 
 if (COVERAGE)
     if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT CMAKE_CXX_COMPILER_ID MATCHES "GNU")
@@ -65,12 +66,14 @@ set(CMAKE_CXX_EXTENSIONS NO)
 include_directories(${XTENSOR_FFTW_INCLUDE_DIR})
 
 # .. xtensor
-find_package(xtensor REQUIRED)
+set(xtensor_REQUIRED_VERSION 0.21.2)
+find_package(xtensor ${xtensor_REQUIRED_VERSION} REQUIRED)
 message(STATUS "Found xtensor: ${xtensor_INCLUDE_DIRS}/xtensor")
 include_directories(${xtensor_INCLUDE_DIRS})
 
 # .. xtl
-find_package(xtl REQUIRED)
+set(xtl_REQUIRED_VERSION 0.6.9)
+find_package(xtl ${xtl_REQUIRED_VERSION} REQUIRED)
 message(STATUS "Found xtl: ${xtl_INCLUDE_DIRS}/xtl")
 include_directories(${xtl_INCLUDE_DIRS})
 
@@ -163,4 +166,4 @@ configure_file(${PROJECT_NAME}.pc.in
         "${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}.pc"
         @ONLY)
 install(FILES "${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}.pc"
-        DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")
+        DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig/")

README.md

@@ -46,6 +46,10 @@ make install
 * [FFTW](http://www.fftw.org/) version 3
 * A compiler supporting C++14
 
+| `xtensor-fftw` | `xtensor` | `xtl`   | `fftw`  |
+|----------------|-----------|---------|---------|
+|  master        | ^0.20.10  |  ^0.6.7 | ^3.3.8  |
+
 ## Usage
 
 _xtensor-fftw_ is a header-only library.

include/xtensor-fftw/basic.hpp

@@ -32,6 +32,8 @@
 
 #include <fftw3.h>
 
+#include "xtensor-fftw_config.hpp"
+
 #ifdef __CLING__
   #pragma cling load("fftw3")
 #endif
@@ -386,7 +388,8 @@ namespace xt {
 
       auto plan = fftw_plan_dft_caller<dim, fftw_direction, fftw_123dim, input_t, output_t, fftw_plan_dft, half_plus_one_out, half_plus_one_in>(input, output, FFTW_ESTIMATE, odd_last_dim);
       if (plan == nullptr) {
-        throw std::runtime_error("Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
+        XTENSOR_FFTW_THROW(std::runtime_error,
+                           "Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
       }
 
       fftw_execute(plan);
@@ -414,7 +417,8 @@ namespace xt {
 
       auto plan = fftw_plan_dft_caller<dim, fftw_direction, fftw_123dim, input_t, output_t, fftw_plan_dft, half_plus_one_out, half_plus_one_in>(input, output, FFTW_ESTIMATE, odd_last_dim);
       if (plan == nullptr) {
-        throw std::runtime_error("Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
+        XTENSOR_FFTW_THROW(std::runtime_error,
+                           "Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
       }
 
       fftw_execute(plan);
@@ -446,7 +450,8 @@ namespace xt {
 
       auto plan = fftw_plan_dft_caller<dim, fftw_direction, fftw_123dim, input_t, output_t, fftw_plan_dft, half_plus_one_out, half_plus_one_in>(input_conj, output, FFTW_ESTIMATE);
       if (plan == nullptr) {
-        throw std::runtime_error("Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
+        XTENSOR_FFTW_THROW(std::runtime_error,
+                           "Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
       }
 
       fftw_execute(plan);
@@ -474,7 +479,8 @@ namespace xt {
 
       auto plan = fftw_plan_dft_caller<dim, fftw_direction, fftw_123dim, input_t, output_t, fftw_plan_dft, half_plus_one_out, half_plus_one_in>(input, output, FFTW_ESTIMATE);
       if (plan == nullptr) {
-        throw std::runtime_error("Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
+        XTENSOR_FFTW_THROW(std::runtime_error,
+                           "Plan creation returned nullptr. This usually means FFTW cannot create a plan for the given arguments (e.g. a non-destructive multi-dimensional real FFT is impossible in FFTW).");
       }
 
       fftw_execute(plan);

include/xtensor-fftw/xtensor-fftw_config.hpp

@@ -13,4 +13,22 @@
 #define XTENSOR_FFTW_VERSION_MINOR 2
 #define XTENSOR_FFTW_VERSION_PATCH 5
 
+// Define if the library is going to be using exceptions.
+#if (!defined(__cpp_exceptions) && !defined(__EXCEPTIONS) && !defined(_CPPUNWIND))
+#undef XTENSOR_FFTW_DISABLE_EXCEPTIONS
+#define XTENSOR_FFTW_DISABLE_EXCEPTIONS
+#endif
+
+// Exception support.
+#if defined(XTENSOR_FFTW_DISABLE_EXCEPTIONS)
+#include <iostream>
+#define XTENSOR_FFTW_THROW(_, msg)       \
+    {                                    \
+      std::cerr << msg << std::endl;     \
+      std::abort();                      \
+    }
+#else
+#define XTENSOR_FFTW_THROW(exception, msg) throw exception(msg)
+#endif
+
 #endif //XTENSOR_FFTW_CONFIG_HPP

test/CMakeLists.txt

@@ -33,12 +33,25 @@ string(TOUPPER "${CMAKE_BUILD_TYPE}" U_CMAKE_BUILD_TYPE)
 
 set(CMAKE_CXX_STANDARD 14)
 
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR (CMAKE_CXX_COMPILER_ID MATCHES "Intel" AND NOT WIN32))
+    if (DISABLE_EXCEPTIONS)
+        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")
+    endif()
+endif()
+
 if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     add_compile_options(-ftemplate-backtrace-limit=0)
+    if (DISABLE_EXCEPTIONS)
+        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")
+    endif()
 endif()
 
 if(MSVC)
-    add_compile_options(/EHsc /MP /bigobj)
+    if (DISABLE_EXCEPTIONS)
+        add_compile_options(/EHs-c- /MP /bigobj)
+    else()
+        add_compile_options(/EHsc /MP /bigobj)
+    endif()
     set(CMAKE_EXE_LINKER_FLAGS /MANIFEST:NO)
     foreach(flag_var
             CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE

test/basic_interface_fft.cpp

@@ -106,4 +106,4 @@ TYPED_TEST(TransformAndInvert_FFT, FFT_4D_xtensor) {
   assert_results_complex(a, a_fourier, should_be_a);
 }
 
-*/
+*/