Merge pull request #184 from JohanMabille/std_filesystem

Switched from gulrak filesystem to std filesystem

Author: JohanMabille

CMakeLists.txt

@@ -125,16 +125,6 @@ target_compile_features(xtensor-io INTERFACE cxx_std_17)
 
 include_directories(${GTEST_INCLUDE_DIRS})
 
-find_path(ghc-filesystem-include REQUIRED
-    NAMES "ghc/filesystem.hpp"
-    DOC "Path to include directory of https://github.com/gulrak/filesystem"
-    )
-target_include_directories(xtensor-io
-    INTERFACE
-    $<BUILD_INTERFACE:${ghc-filesystem-include}>
-    $<INSTALL_INTERFACE:include>
-)
-
 target_include_directories(xtensor-io
     INTERFACE
     $<BUILD_INTERFACE:${XTENSOR_IO_INCLUDE_DIR}>

README.md

@@ -27,7 +27,7 @@ Reading and writing image, sound and npz file formats to and from xtensor data s
 ```bash
 mamba install xtensor-io -c conda-forge
 ```
-- `xtensor-io` depends on `xtensor` `^0.26.0` and [filesystem](https://github.com/gulrak/filesystem).
+- `xtensor-io` depends on `xtensor` `^0.26.0
 
 - `OpenImageIO`, `libsndfile`, `zlib`, `HighFive`, and `blosc` are optional dependencies to `xtensor-io`
 

environment-dev.yml

@@ -17,5 +17,3 @@ dependencies:
   - google-cloud-cpp >=3.0,<4
   - aws-sdk-cpp >=1.11,<2
   - xtensor=0.26.0
-  - cpp-filesystem >=1.5,<2
-

include/xtensor-io/xchunk_store_manager.hpp

@@ -4,7 +4,7 @@
 #include <vector>
 #include <array>
 
-#include "ghc/filesystem.hpp"
+#include <filesystem>
 
 #include <xtl/xsequence.hpp>
 
@@ -671,7 +671,7 @@ namespace xt
     template <class EC, class IP>
     inline std::string xchunk_store_manager<EC, IP>::get_temporary_directory() const
     {
-        namespace fs = ghc::filesystem;
+        namespace fs = std::filesystem;
         fs::path tmp_dir = fs::temp_directory_path();
         std::size_t count = 0;
         while(fs::exists(tmp_dir / std::to_string(count)))
@@ -684,7 +684,7 @@ namespace xt
     template <class EC, class IP>
     inline void xchunk_store_manager<EC, IP>::reset_to_directory(const std::string& directory)
     {
-        namespace fs = ghc::filesystem;
+        namespace fs = std::filesystem;
         fs::remove_all(get_directory());
         fs::rename(directory, get_directory());
         m_unload_index = 0u;

include/xtensor-io/xio_disk_handler.hpp

@@ -1,13 +1,13 @@
 #ifndef XTENSOR_IO_DISK_HANDLER_HPP
 #define XTENSOR_IO_DISK_HANDLER_HPP
 
-#include <ghc/filesystem.hpp>
+#include <filesystem>
 #include <xtensor/containers/xarray.hpp>
 #include <xtensor/core/xexpression.hpp>
 #include "xio_stream_wrapper.hpp"
 #include "xfile_array.hpp"
 
-namespace fs = ghc::filesystem;
+namespace fs = std::filesystem;
 
 namespace xt
 {

test/test_xchunk_store_manager.cpp

@@ -17,7 +17,7 @@
 
 namespace xt
 {
-    namespace fs = ghc::filesystem;
+    namespace fs = std::filesystem;
 
     template <class S>
     inline auto make_test_chunked_array(const S& shape,