Add test for chunked zarray assignment

Author: davidbrochart

include/xtensor-zarr/xzarr_aws_store.hpp

@@ -115,7 +115,7 @@ namespace xt
         request.SetKey(m_path);
 
         std::shared_ptr<Aws::IOStream> writer = Aws::MakeShared<Aws::FStream>("SampleAllocationTag", m_path.c_str(), std::ios_base::in | std::ios_base::binary);
-        writer->write(value, size);
+        writer->write(value, (std::streamsize)size);
         writer->flush();
 
         request.SetBody(writer);

include/xtensor-zarr/xzarr_common.hpp

@@ -20,11 +20,11 @@ namespace xt
         std::size_t zarr_major;
         if (i == std::string::npos)
         {
-            zarr_major = std::stoi(zarr_version);
+            zarr_major = (std::size_t)std::stoi(zarr_version);
         }
         else
         {
-            zarr_major = std::stoi(zarr_version.substr(0, i));
+            zarr_major = (std::size_t)std::stoi(zarr_version.substr(0, i));
         }
         if ((zarr_major < 2) || (zarr_major > 3))
         {

include/xtensor-zarr/xzarr_file_system_store.hpp

@@ -129,7 +129,7 @@ namespace xt
             }
         }
         std::ofstream stream(m_path, std::ofstream::binary);
-        stream.write(value, size);
+        stream.write(value, (std::streamsize)size);
         stream.flush();
     }
 

include/xtensor-zarr/xzarr_gcs_store.hpp

@@ -95,7 +95,7 @@ namespace xt
     void xzarr_gcs_stream::assign(const char* value, std::size_t size)
     {
         auto writer = m_client.WriteObject(m_bucket, m_path);
-        writer.write(value, size);
+        writer.write(value, (std::streamsize)size);
         writer.flush();
     }
 

test/test_zarr.cpp

@@ -156,7 +156,7 @@ namespace xt
                               "data/root/arthur/dent/c1/1",
                               "data/root/arthur/dent/c2/0",
                               "data/root/arthur/dent/c2/1"};
-        for (int i = 0; i < 6; i++)
+        for (unsigned long int i = 0; i < 6; i++)
         {
             EXPECT_EQ(keys1[i], ref1[i]);
         }
@@ -165,7 +165,7 @@ namespace xt
         auto keys2 = s2.list();
         std::string ref2[] = {"android.array.json",
                               "paranoid.group.json"};
-        for (int i = 0; i < 2; i++)
+        for (unsigned long int i = 0; i < 2; i++)
         {
             EXPECT_EQ(keys2[i], ref2[i]);
             // we don't have rights to erase objects in this bucket as an anonymous client
@@ -184,4 +184,15 @@ namespace xt
         auto h = create_zarr_hierarchy("h_xtensor.zr2", zarr_version);
         zarray z1 = h.create_array("/arthur/dent", shape, chunk_shape, "<f8", 'C', '.', xio_gzip_config(), attrs, pool_size, fill_value);
     }
+
+    TEST(xzarr_hierarchy, zarr_assign)
+    {
+        std::vector<size_t> shape = {4, 4};
+        std::vector<size_t> chunk_shape = {2, 2};
+        auto h1 = create_zarr_hierarchy("src.zr3");
+        zarray z1 = h1.create_array("/", shape, chunk_shape, "<f8", 'C', '.', xio_gzip_config());
+        auto h2 = create_zarr_hierarchy("dst.zr3");
+        zarray z2 = h2.create_array("/", shape, chunk_shape, "<f8", 'C', '.', xio_gzip_config());
+        z2 = z1;
+    }
 }