Merge pull request #2510 from tdegeus/cast

JohanMabille · web-flow · commit d122fb3044c1 · 2022-05-06T16:42:33.000+02:00
Adding cast to deal with xtensor-python's signedness of shape
diff --git a/include/xtensor/xsort.hpp b/include/xtensor/xsort.hpp
@@ -152,7 +152,7 @@ namespace xt
         {
             const auto& de = e.derived_cast();
             R ev;
-            ev.resize({de.size()});
+            ev.resize({static_cast<typename R::shape_type::value_type>(de.size())});
 
             std::copy(de.cbegin(), de.cend(), ev.begin());
             std::sort(ev.begin(), ev.end());

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ namespace xt`
`152`	`152`	`{`
`153`	`153`	`const auto& de = e.derived_cast();`
`154`	`154`	`R ev;`
`155`		`- ev.resize({de.size()});`
	`155`	`+ ev.resize({static_cast<typename R::shape_type::value_type>(de.size())});`
`156`	`156`
`157`	`157`	`std::copy(de.cbegin(), de.cend(), ev.begin());`
`158`	`158`	`std::sort(ev.begin(), ev.end());`