fix(addon-webgl): request model clear when clearing shared atlas texture#6018
Open
RuanCarvalhoo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When multiple terminals share the same WebGL texture atlas, calling clearTextureAtlas on one terminal clears the shared atlas pages and glyph caches, but sibling terminals are not notified to rebuild their model.
This leaves stale vertex texture coordinates in unchanged rows on sibling terminals and can render text garbled or blank until a full refresh happens.
Closes #6014
Solution
Set _requestClearModel = true in TextureAtlas.clearTexture after clearing pages/caches.
This aligns clearTexture with other atlas-wide mutation paths that already request a shared model rebuild, so every renderer sharing the atlas performs a full model update on the next frame.