Skip to content

Feat/infer reminder content type#84

Open
simone3991 wants to merge 5 commits intomainfrom
feat/infer-reminder-content-type
Open

Feat/infer reminder content type#84
simone3991 wants to merge 5 commits intomainfrom
feat/infer-reminder-content-type

Conversation

@simone3991
Copy link
Copy Markdown
Member

No description provided.

@simone3991 simone3991 requested a review from khaelys September 22, 2021 16:04
Comment thread src/Clockify/EntryFillRemindService.cs Outdated
Comment thread src/Clockify/EntryFillRemindService.cs Outdated
await turn.SendActivityAsync(new Activity(text: "",
attachments:new List<Attachment> {attachment}), token);
}
// TODO: handle fallback reminder
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using an exception instead? Pro and cons?

{
var attachment = new Attachment(contentType, content);
await turn.SendActivityAsync(new Activity(text: "",
attachments:new List<Attachment> {attachment}), token);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants