Skip to content

fix: remove v from tag when looking for the version #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xverges merged 1 commit into from
Nov 22, 2025
Merged

fix: remove v from tag when looking for the version #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ jobs:
PACKAGE_IMPORT_NAME=$(echo $PACKAGE_NAME | tr '-' '_')

# Install from TestPyPI, falling back to PyPI for dependencies
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ "$PACKAGE_NAME==${{ needs.release-please.outputs.tag_name }}"
# Tags are v-prefixed. Versions are not.
TAG_NAME="${{ needs.release-please.outputs.tag_name }}"
VERSION="${TAG_NAME#v}"
pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ "$PACKAGE_NAME==$VERSION"

# Simple import check
python -c "import $PACKAGE_IMPORT_NAME; print(f'Successfully imported $PACKAGE_IMPORT_NAME version {$PACKAGE_IMPORT_NAME.__version__}')"
Expand Down