Centralize Trait_View_Stream_Permission loading

Each of the 5 read abilities (get-records, get-record, get-alerts,
get-connectors, get-exclusion-rules) previously did its own
require_once for trait-view-stream-permission.php at the top of the
class file. A new read ability that forgot the require would silently
fall back to Ability::permission_callback() and gate on
WP_STREAM_SETTINGS_CAPABILITY instead of view_stream.

Move the require_once into the two chokepoints that actually load
ability files: Abilities::load_abilities() for production and
Abilities_TestCase::setUp() for PHPUnit. New abilities now get the
trait available automatically -- no per-file require to forget.

Verified via PHP introspection (trait_exists, class_uses on all 5
ability classes) and a live REST smoke test that admin GETs return
200 and subscriber GETs return 403 across all five read abilities.

Author: PatelUtkarsh

abilities/class-ability-get-alerts.php

@@ -7,8 +7,6 @@
 
 namespace WP_Stream;
 
-require_once __DIR__ . '/trait-view-stream-permission.php';
-
 /**
  * Class - Ability_Get_Alerts
  */

abilities/class-ability-get-connectors.php

@@ -7,8 +7,6 @@
 
 namespace WP_Stream;
 
-require_once __DIR__ . '/trait-view-stream-permission.php';
-
 /**
  * Class - Ability_Get_Connectors
  */

abilities/class-ability-get-exclusion-rules.php

@@ -7,8 +7,6 @@
 
 namespace WP_Stream;
 
-require_once __DIR__ . '/trait-view-stream-permission.php';
-
 /**
  * Class - Ability_Get_Exclusion_Rules
  */

abilities/class-ability-get-record.php

@@ -7,8 +7,6 @@
 
 namespace WP_Stream;
 
-require_once __DIR__ . '/trait-view-stream-permission.php';
-
 /**
  * Class - Ability_Get_Record
  */

abilities/class-ability-get-records.php

@@ -7,8 +7,6 @@
 
 namespace WP_Stream;
 
-require_once __DIR__ . '/trait-view-stream-permission.php';
-
 /**
  * Class - Ability_Get_Records
  */

classes/class-abilities.php

@@ -221,6 +221,13 @@ public function get_ability_slugs() {
 	public function load_abilities() {
 		$dir = trailingslashit( $this->plugin->locations['dir'] ) . 'abilities/';
 
+		// Load shared trait once before any ability file is included. The
+		// read abilities `use Trait_View_Stream_Permission` and PHP needs the
+		// trait declared before the class declaration is parsed. Doing it
+		// here keeps the require centralized -- new read abilities don't
+		// have to remember to require the trait themselves.
+		require_once $dir . 'trait-view-stream-permission.php';
+
 		foreach ( $this->get_ability_slugs() as $slug ) {
 			$file = $dir . 'class-ability-' . $slug . '.php';
 			if ( ! is_readable( $file ) ) {

tests/phpunit/abilities/abilities-testcase.php

@@ -48,6 +48,14 @@ public function setUp(): void {
 			$this->markTestSkipped( 'Requires WordPress 6.9+ (Abilities API).' );
 		}
 
+		// Mirror Abilities::load_abilities(): the trait must be loaded before
+		// any ability class file is `require_once`'d by a test setUp, since the
+		// `use Trait_View_Stream_Permission` in the class body needs the trait
+		// declared at parse time. In production the require lives in
+		// load_abilities(), but tests bypass that path and pull each ability
+		// file in directly.
+		require_once $this->plugin->locations['dir'] . 'abilities/trait-view-stream-permission.php';
+
 		$this->admin_user_id      = self::factory()->user->create( array( 'role' => 'administrator' ) );
 		$this->subscriber_user_id = self::factory()->user->create( array( 'role' => 'subscriber' ) );