Update to PHP 8.4 and migrate to pnpm#314
Conversation
mauteri
changed the title
| // Multisite config. | ||
| define( 'MULTISITE', true ); | ||
| define( 'SUBDOMAIN_INSTALL', false ); // Matching VIP setup. | ||
| define( 'SUBDOMAIN_INSTALL', true ); |
There was a problem hiding this comment.
@nandotess @bartoszgadomski we made this change on Ziff, but seems like it should be done here as well since you use network.local.wpenv.net and main.local.wpenv.net in the template setup. Am I understanding that correctly? Let me know your thoughts (cc @landbryo)
There was a problem hiding this comment.
Sounds like you're right
There was a problem hiding this comment.
I would prefer to keep this mathing VIP.
setup-multisite.sh changes this to true during setup and revert it back at the end of the script.
I need to be honest I don't know the issues having this set to false. But I know for sure this should not block development and site creation. On Vox, this is still false. On DK this is false and localhost setup is working.
nandotess
left a comment
nandotess
left a comment
There was a problem hiding this comment.
I don't think it's a good idea to change to PHP 8.4 yet since it's still on testing mode on VIP (thanks to Miina I have learned this today).
…ffect setup and is default VIP setting.
| else | ||
| echo "Node modules cache miss - installing dependencies" | ||
| npm install --ignore-scripts --prefer-offline --no-audit | ||
| pnpm install --ignore-scripts --prefer-offline |
There was a problem hiding this comment.
@mauteri I'm interested in learning more about using pnpm before it's used as a default on projects. My only concern about it is having certain tooling on some projects, but not on others. Does changing to pnpm offer advantages that all projects should use? Are there any downsides to using pnpm that need to be considered on projects?
4 participants
Updates template to PHP 8.4 and migrates from npm to pnpm to match the ziffdavis-wp-platform repository configuration.
Changes
We will merge these changes after VIP is out of PHP 8.4 testing mode.