feat: support typst#54
Open
b-yp wants to merge 3 commits into
Open
Conversation
Owner
|
Hi @b-yp Just simplified the typst package. Feel free to continue any works if you want :) |
Author
|
Thank you @xyhp915 ! The code you optimized is fantastic; it eliminated a lot of JS file imports and switched to using npm imports. 👍 |
Author
|
I just noticed there's another PR here. Can this PR be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I just added support for typst in the plugin, and it seems to be working fine. However, I'm unsure if this PR can be merged, as it depends on too many files, and the files are not loaded using logseq.Experiments.loadScripts(). This is the only way I could do it; I can't find a better solution. If you have any other thoughts, please let me know.
20241031_100658.mp4