Skip to content

Commit 80b778d

Browse files
committed
Fix the calls to the getters
1 parent 4bdf1a4 commit 80b778d

2 files changed

Lines changed: 11 additions & 14 deletions

File tree

demo/js/app.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ export const app = (window.app = createApp({
7171
const { thumbnails } = parser.metadata;
7272

7373
thumbnail.value = thumbnails['220x124']?.src;
74-
layerCount.value = job.layers()?.length;
74+
layerCount.value = job.layers?.length;
7575
const colors = extrusionColor instanceof Array ? extrusionColor : [extrusionColor];
7676
const currentSettings = {
77-
maxLayer: job.layers()?.length,
78-
endLayer: job.layers()?.length,
77+
maxLayer: job.layers?.length,
78+
endLayer: job.layers?.length,
7979
singleLayerMode,
8080
renderTravel,
8181
travelColor: '#' + travelColor.getHexString(),
@@ -94,7 +94,7 @@ export const app = (window.app = createApp({
9494
};
9595

9696
Object.assign(settings.value, currentSettings);
97-
preview.endLayer = job.layers()?.length;
97+
preview.endLayer = job.layers?.length;
9898
};
9999

100100
const loadGCodeFromServer = async (filename) => {
@@ -117,12 +117,12 @@ export const app = (window.app = createApp({
117117
if (loadProgressive) {
118118
const { commands } = preview.parser.parseGCode(gcode);
119119
preview.interpreter.execute(commands, preview.job);
120-
if (preview.job.layers() === null) {
120+
if (preview.job.layers === null) {
121121
console.warn('Job is not planar');
122122
preview.render();
123123
return;
124124
}
125-
await preview.renderAnimated(Math.ceil(preview.job.layers().length / 60));
125+
await preview.renderAnimated(Math.ceil(preview.job.layers.length / 60));
126126
} else {
127127
preview.processGCode(gcode);
128128
}
@@ -212,7 +212,7 @@ export const app = (window.app = createApp({
212212
preview.lastSegmentColor = settings.value.highlightLastSegment ? settings.value.lastSegmentColor : undefined;
213213

214214
debounce(() => {
215-
preview.renderAnimated(Math.ceil(preview.job.layers().length / 60));
215+
preview.renderAnimated(Math.ceil(preview.job.layers.length / 60));
216216
});
217217
});
218218
});

src/webgl-preview.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ export class WebGLPreview {
305305

306306
this.renderLayerIndex = 0;
307307

308-
if (this.job.layers() === null) {
308+
if (this.job.layers === null) {
309309
console.warn('Job is not planar');
310310
this.render();
311311
return;
@@ -317,7 +317,7 @@ export class WebGLPreview {
317317
private renderFrameLoop(layerCount: number): Promise<void> {
318318
return new Promise((resolve) => {
319319
const loop = () => {
320-
if (this.renderLayerIndex >= this.job.layers().length - 1) {
320+
if (this.renderLayerIndex >= this.job.layers.length - 1) {
321321
resolve();
322322
} else {
323323
this.renderFrame(layerCount);
@@ -331,11 +331,8 @@ export class WebGLPreview {
331331
private renderFrame(layerCount: number): void {
332332
this.group = this.createGroup('layer' + this.renderLayerIndex);
333333

334-
const endIndex = Math.min(this.renderLayerIndex + layerCount, this.job.layers().length - 1);
335-
const pathsToRender = this.job
336-
.layers()
337-
.slice(this.renderLayerIndex, endIndex)
338-
.flatMap((l) => l);
334+
const endIndex = Math.min(this.renderLayerIndex + layerCount, this.job.layers.length - 1);
335+
const pathsToRender = this.job.layers.slice(this.renderLayerIndex, endIndex).flatMap((l) => l);
339336

340337
this.renderGeometries(pathsToRender.filter((path) => path.travelType === 'Extrusion'));
341338
this.renderLines(

0 commit comments

Comments
 (0)