Improve tests to not assume the value of the default

Author: sophiedeziel

src/__tests__/job.ts

@@ -1,5 +1,5 @@
 import { test, expect, describe } from 'vitest';
-import { Job, State } from '../job';
+import { Job, State, LayersIndexer } from '../job';
 import { PathType, Path } from '../path';
 
 test('it has an initial state', () => {
@@ -96,7 +96,7 @@ describe('.layers', () => {
     expect(layers?.[0].length).toEqual(2);
   });
 
-  test('travel paths moving z above the tolerance create a new layer', () => {
+  test('travel paths moving z above the default tolerance create a new layer', () => {
     const job = new Job();
 
     append_path(job, PathType.Extrusion, [
@@ -105,7 +105,7 @@ describe('.layers', () => {
     ]);
     append_path(job, PathType.Travel, [
       [5, 6, 0],
-      [5, 6, 1]
+      [5, 6, LayersIndexer.DEFAULT_TOLERANCE + 0.01]
     ]);
 
     const layers = job.layers;
@@ -117,7 +117,7 @@ describe('.layers', () => {
     expect(layers?.[1].length).toEqual(1);
   });
 
-  test('travel paths moving z under the tolerance are on the same layer', () => {
+  test('travel paths moving z under the default tolerance are on the same layer', () => {
     const job = new Job();
 
     append_path(job, PathType.Extrusion, [
@@ -126,7 +126,7 @@ describe('.layers', () => {
     ]);
     append_path(job, PathType.Travel, [
       [5, 6, 0],
-      [5, 6, 0.04]
+      [5, 6, LayersIndexer.DEFAULT_TOLERANCE - 0.01]
     ]);
 
     const layers = job.layers;

src/job.ts

@@ -17,7 +17,7 @@ export class State {
 
 type JobOptions = {
   state?: State;
-  minLayerThreshold: number;
+  minLayerThreshold?: number;
 };
 
 export class Job {
@@ -29,7 +29,7 @@ export class Job {
   private indexers: Indexer[];
   inprogressPath: Path | undefined;
 
-  constructor(opts: JobOptions = { minLayerThreshold: 0.05 }) {
+  constructor(opts: JobOptions = {}) {
     this.paths = [];
     this.state = opts.state || State.initial;
     this.layersPaths = [[]];
@@ -89,7 +89,7 @@ export class Job {
 }
 
 class NonApplicableIndexer extends Error {}
-class Indexer {
+export class Indexer {
   protected indexes: Record<string, Path[]> | Path[][];
   constructor(indexes: Record<string, Path[]> | Path[][]) {
     this.indexes = indexes;
@@ -100,7 +100,7 @@ class Indexer {
   }
 }
 
-class TravelTypeIndexer extends Indexer {
+export class TravelTypeIndexer extends Indexer {
   protected declare indexes: Record<string, Path[]>;
   constructor(indexes: Record<string, Path[]>) {
     super(indexes);
@@ -120,10 +120,11 @@ class NonPlanarPathError extends NonApplicableIndexer {
     super("Non-planar paths can't be indexed by layer");
   }
 }
-class LayersIndexer extends Indexer {
+export class LayersIndexer extends Indexer {
+  static readonly DEFAULT_TOLERANCE = 0.05;
   protected declare indexes: Path[][];
   private tolerance: number;
-  constructor(indexes: Path[][], tolerance: number = 0.05) {
+  constructor(indexes: Path[][], tolerance: number = LayersIndexer.DEFAULT_TOLERANCE) {
     super(indexes);
     this.tolerance = tolerance;
   }