Skip to content

Bring back a representation of layers #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiedeziel merged 6 commits into from
Oct 19, 2024
Merged

Bring back a representation of layers #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08035b9
Remove the code enum (#229)
sophiedeziel Oct 17, 2024
a122486
Bring back a representation of layers
sophiedeziel Oct 17, 2024
3dbb708
No need to expose isPlanar now
sophiedeziel Oct 17, 2024
a712504
Make layers 100% progressive rendering ready
sophiedeziel Oct 18, 2024
c820fc7
Layer number, height and z
sophiedeziel Oct 18, 2024
e4442eb
fix the splitting logic
sophiedeziel Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions demo/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export const app = (window.app = createApp({
const updateUI = async () => {
const {
parser,
countLayers,
extrusionColor,
topLayerColor,
lastSegmentColor,
Expand All @@ -64,17 +65,16 @@ export const app = (window.app = createApp({
renderExtrusion,
lineWidth,
renderTubes,
extrusionWidth,
job
extrusionWidth
} = preview;
const { thumbnails } = parser.metadata;

thumbnail.value = thumbnails['220x124']?.src;
layerCount.value = job.layers?.length;
layerCount.value = countLayers;
const colors = extrusionColor instanceof Array ? extrusionColor : [extrusionColor];
const currentSettings = {
maxLayer: job.layers?.length,
endLayer: job.layers?.length,
maxLayer: countLayers,
endLayer: countLayers,
singleLayerMode,
renderTravel,
travelColor: '#' + travelColor.getHexString(),
Expand All @@ -93,7 +93,7 @@ export const app = (window.app = createApp({
};

Object.assign(settings.value, currentSettings);
preview.endLayer = job.layers?.length;
preview.endLayer = countLayers;
};

const loadGCodeFromServer = async (filename) => {
Expand Down Expand Up @@ -126,7 +126,7 @@ export const app = (window.app = createApp({
preview.render();
return;
}
await preview.renderAnimated(Math.ceil(preview.job.layers?.length / 60));
await preview.renderAnimated(Math.ceil(preview.countLayers / 60));
} else {
preview.render();
}
Expand Down
Loading