Add message error handler#144
Merged
Merged
Conversation
| """ | ||
| Returns: | ||
| The optional callback to call when an exception is raised while processing | ||
| a sync message. The callback receives the exception, the raw message bytes, |
Contributor
There was a problem hiding this comment.
I think that this handler should be called for any message type, not just a sync message.
| _handled = self._on_message_error(exc, message, channel) | ||
| handled = await _handled if isawaitable(_handled) else _handled | ||
| if handled: | ||
| continue |
Contributor
There was a problem hiding this comment.
It looks like we can have this logic once for all message types just after async for message in channel:, instead of duplicating it for all message types?
Contributor
There was a problem hiding this comment.
Yes, this looks good.
davidbrochart
approved these changes
Jun 1, 2026
Member
Author
|
Can we release next version? Should it be 0.17.0? |
Contributor
|
I released v0.16.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jupyterlab/jupyter-collaboration#584 (comment)
There already is
exception_handlerbut it is only for logging - it is called after catching the exception and stoping the room. The use case here is different - we want to be able to continue the room execution.Modelled on
on_messageproperty/setter pattern.