feat(webui): Integrate Monaco editor for future Presto SQL query input.#1108
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR adds the monaco editor to the webui for SQL input, and adds support for highlighting and autocomplete for sql syntax like
SELECT,WHEREetc.I also added a "run" button, which seemed more appropriate than "search" since we support more queries with sql.
They only render when presto is set as query engine in settings.
Checklist
breaking change.
Validation performed
Editor loads. To validate yourself, you must change from ClpQueryEngine from native to presto in settings.json in public folder.
Summary by CodeRabbit
New Features
Enhancements
Chores