Fix lint

Author: xwei19

lint-requirements.txt

@@ -1,6 +1,4 @@
-# Lock to v19.x until we can upgrade our code to fix new v20 issues.
 clang-format>=20.1.0
-# Lock to v19.x until we can upgrade our code to fix new v20 issues.
 clang-tidy>=19.1.0
 colorama>=0.4.6
 gersemi>=0.16.2

src/ystdlib/containers/test/test_Array.cpp

@@ -75,36 +75,36 @@ void test_list_initialization_in_function_call(
 
 namespace ystdlib::containers::test {
 TEST_CASE("test_array_empty", "[containers][Array]") {
-    Array<int> arr(0);
+    Array<size_t> arr(0);
     REQUIRE(arr.empty());
     // NOLINTNEXTLINE(readability-container-size-empty)
     REQUIRE((0 == arr.size()));
     REQUIRE((arr.begin() == arr.end()));
 }
 
 TEST_CASE("test_array_reference", "[containers][Array]") {
-    Array<int> arr(cBufferSize);
-    for (int idx{0}; idx < cBufferSize; ++idx) {
+    Array<size_t> arr(cBufferSize);
+    for (size_t idx{0}; idx < cBufferSize; ++idx) {
         arr.at(idx) = idx;
     }
     auto const& arr_const_ref = arr;
     REQUIRE(std::ranges::equal(arr, arr_const_ref));
 }
 
 TEST_CASE("test_array_ranged_copy", "[containers][Array]") {
-    std::vector<int> vec;
-    for (int idx{0}; idx < cBufferSize; ++idx) {
+    std::vector<size_t> vec;
+    for (size_t idx{0}; idx < cBufferSize; ++idx) {
         vec.push_back(idx);
     }
-    Array<int> arr(cBufferSize);
+    Array<size_t> arr(cBufferSize);
     std::ranges::copy(vec, arr.begin());
     REQUIRE(std::ranges::equal(vec, arr));
 }
 
 TEST_CASE("test_array_movable", "[containers][Array]") {
-    Array<int> arr(cBufferSize);
-    Array<int> reference_array(cBufferSize);
-    for (int idx{0}; idx < cBufferSize; ++idx) {
+    Array<size_t> arr(cBufferSize);
+    Array<size_t> reference_array(cBufferSize);
+    for (size_t idx{0}; idx < cBufferSize; ++idx) {
         arr.at(idx) = idx;
         reference_array.at(idx) = idx;
     }
@@ -113,7 +113,7 @@ TEST_CASE("test_array_movable", "[containers][Array]") {
 }
 
 TEST_CASE("test_array_illegal_access", "[containers][Array]") {
-    Array<int> arr(cBufferSize);
+    Array<size_t> arr(cBufferSize);
     REQUIRE_THROWS_AS(arr.at(-1), std::out_of_range);
     REQUIRE_THROWS_AS(arr.at(cBufferSize), std::out_of_range);
 }

src/ystdlib/error_handling/test/test_Result.cpp

@@ -106,8 +106,8 @@ TEST_CASE("test_result_unique_ptr", "[error_handling][Result]") {
 
     auto const result_has_error{cUniquePtrFunc(true)};
     REQUIRE(result_has_error.has_error());
-    REQUIRE(AlwaysSuccessErrorCode{AlwaysSuccessErrorCodeEnum::Success} == result_has_error.error()
-    );
+    REQUIRE(AlwaysSuccessErrorCode{AlwaysSuccessErrorCodeEnum::Success}
+            == result_has_error.error());
 }
 
 TEST_CASE("test_result_unique_ptr_in_main", "[error_handling][Result]") {

src/ystdlib/wrapped_facade_headers/test/test_sys_types.cpp

@@ -3,8 +3,6 @@
 #include <catch2/catch_test_macros.hpp>
 
 namespace ystdlib::wrapped_facade_headers::test {
-
-namespace {
 TEST_CASE("test_sys_types_u_char", "[wrapped_facade_headers][sys_types][u_char]") {
     u_char const i{0};
     REQUIRE(0 == i);
@@ -165,6 +163,4 @@ TEST_CASE("test_sys_types_fsfilcnt_t", "[wrapped_facade_headers][sys_types][fsfi
     fsfilcnt_t const i{0};
     REQUIRE(0 == i);
 }
-}
-
 }  // namespace ystdlib::wrapped_facade_headers::test

taskfiles/lint-cpp.yaml

@@ -53,7 +53,7 @@ tasks:
     aliases:
       - "cpp-static-fix"
     desc: "Runs the C++ static analyzers. Only checks for warnings and violations."
-    sources: &cpp_format_src_files
+    sources: &cpp_static_src_files
       - "{{.G_CMAKE_CACHE}}"
       - "{{.G_COMPILE_COMMANDS_DB}}"
       - "{{.G_LINT_VENV_CHECKSUM_FILE}}"
@@ -69,12 +69,10 @@ tasks:
         vars:
           FLAGS:
             - "--config-file '{{.ROOT_DIR}}/.clang-tidy'"
-            - "-p '{{.G_SPIDER_COMPILE_COMMANDS_DB}}'"
-          INCLUDE_PATTERNS:
-            - "{{.G_SRC_SPIDER_DIR}}/**"
-            - "{{.G_TEST_DIR}}/**"
+            - "-p '{{.G_COMPILE_COMMANDS_DB}}'"
+          INCLUDE_PATTERNS: ["*.cpp", "*.h", "*.hpp", "*.inc"]
           OUTPUT_DIR: "{{.G_LINT_CLANG_TIDY_DIR}}"
-          ROOT_PATHS: *cpp_format_src_files
+          ROOT_PATHS: *cpp_static_src_files
           VENV_DIR: "{{.G_LINT_VENV_DIR}}"
 
   cpp-configs: