modify according to coderabbit suggestions

Author: PacificViking

CMakeLists.txt

@@ -98,7 +98,7 @@ install(TARGETS
         LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
         ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
         RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
-        FILE_SET HEADERS
+        # FILE_SET HEADERS
 )
 
 install(EXPORT ystdlib-targets NAMESPACE ystdlib:: DESTINATION ${ystdlib_INSTALL_CONFIG_DIR})

examples/CMakeLists.txt

@@ -7,7 +7,9 @@ if(ystdlib-examples_IS_TOP_LEVEL)
     include("${CMAKE_SOURCE_DIR}/../build/deps/cmake-settings/settings.cmake" OPTIONAL)
 endif()
 
-set(ystdlib_ROOT "${CMAKE_SOURCE_DIR}/../build/build_install")
+if(NOT DEFINED ystdlib_ROOT)
+    set(ystdlib_ROOT "${CMAKE_SOURCE_DIR}/../build/build_install")
+endif()
 find_package(ystdlib REQUIRED)
 
 add_library(
@@ -17,19 +19,9 @@ add_library(
     types.hpp
     constants.hpp
 )
-target_link_libraries(common PUBLIC ystdlib::error_handling)
+target_link_libraries(common PRIVATE ystdlib::error_handling)
 add_executable(main main.cpp)
 
-get_target_property(_type ystdlib::error_handling TYPE)
-get_target_property(_sources ystdlib::error_handling SOURCES)
-get_target_property(_includes ystdlib::error_handling INCLUDE_DIRECTORIES)
-get_target_property(_libs ystdlib::error_handling LINK_LIBRARIES)
-
-message(STATUS "Target Type: ${_type}")
-message(STATUS "Sources: ${_sources}")
-message(STATUS "Include Dirs: ${_includes}")
-message(STATUS "Linked Libraries: ${_libs}")
-
 target_compile_features(main PRIVATE cxx_std_20)
 target_compile_features(common PRIVATE cxx_std_20)
 

examples/constants.hpp

@@ -1,5 +1,5 @@
-#ifndef YSTDLIB_ERROR_HANDLING_TEST_CONSTANTS_HPP
-#define YSTDLIB_ERROR_HANDLING_TEST_CONSTANTS_HPP
+#ifndef EXAMPLE_CONSTANTS_HPP
+#define EXAMPLE_CONSTANTS_HPP
 
 #include <array>
 #include <string_view>
@@ -15,4 +15,4 @@ constexpr std::array cFailureConditions{std::errc::not_connected, std::errc::tim
 constexpr std::array cNoneFailureConditions{std::errc::broken_pipe, std::errc::address_in_use};
 }  // namespace ystdlib::error_handling::test
 
-#endif  // YSTDLIB_ERROR_HANDLING_TEST_CONSTANTS_HPP
+#endif  // EXAMPLE_CONSTANTS_HPP

examples/types.hpp

@@ -1,5 +1,5 @@
-#ifndef YSTDLIB_ERROR_HANDLING_TEST_TYPES_HPP
-#define YSTDLIB_ERROR_HANDLING_TEST_TYPES_HPP
+#ifndef EXAMPLE_TYPES_HPP
+#define EXAMPLE_TYPES_HPP
 
 #include <cstdint>
 
@@ -24,4 +24,4 @@ YSTDLIB_ERROR_HANDLING_MARK_AS_ERROR_CODE_ENUM(
 );
 YSTDLIB_ERROR_HANDLING_MARK_AS_ERROR_CODE_ENUM(ystdlib::error_handling::test::BinaryErrorCodeEnum);
 
-#endif  // YSTDLIB_ERROR_HANDLING_TEST_TYPES_HPP
+#endif  // EXAMPLE_TYPES_HPP