Skip to content

Commit dbd5f01

Browse files
committed
Tweak cmake logic with rabbit's help.
1 parent 8453a16 commit dbd5f01

6 files changed

Lines changed: 19 additions & 14 deletions

File tree

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
if(NOT TARGET ystdlib::containers)
2-
include("${CMAKE_CURRENT_LIST_DIR}/containers-target.cmake")
1+
if(TARGET ystdlib::containers)
2+
return()
33
endif()
4+
5+
include("${CMAKE_CURRENT_LIST_DIR}/containers-target.cmake")
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
if(@Boost_FOUND@)
2-
find_dependency(Boost @boost_find_package_args@)
1+
if(TARGET ystdlib::error_handling)
2+
return()
33
endif()
44

5-
if(NOT TARGET ystdlib::error_handling)
6-
include("${CMAKE_CURRENT_LIST_DIR}/error_handling-target.cmake")
7-
endif()
5+
find_dependency(Boost @boost_find_package_args@)
6+
include("${CMAKE_CURRENT_LIST_DIR}/error_handling-target.cmake")
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
if(TARGET ystdlib::io_interface)
2+
return()
3+
endif()
4+
15
if(NOT TARGET ystdlib::wrapped_facade_headers)
26
include("${CMAKE_CURRENT_LIST_DIR}/wrapped_facade_headers-target.cmake")
37
endif()
48

5-
if(NOT TARGET ystdlib::io_interface)
6-
include("${CMAKE_CURRENT_LIST_DIR}/io_interface-target.cmake")
7-
endif()
9+
include("${CMAKE_CURRENT_LIST_DIR}/io_interface-target.cmake")
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
if(NOT TARGET ystdlib::wrapped_facade_headers)
2-
include("${CMAKE_CURRENT_LIST_DIR}/wrapped_facade_headers-target.cmake")
1+
if(TARGET ystdlib::wrapped_facade_headers)
2+
return()
33
endif()
4+
5+
include("${CMAKE_CURRENT_LIST_DIR}/wrapped_facade_headers-target.cmake")

cmake/ystdlib-helpers.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ macro(require_argument_values REQUIRED_ARG_NAMES)
99
set(_REQUIRED_ARGS "${REQUIRED_ARG_NAMES}")
1010
foreach(_REQUIRED_ARG IN LISTS _REQUIRED_ARGS)
1111
if(NOT DEFINED ARG_${_REQUIRED_ARG} OR ARG_${_REQUIRED_ARG} STREQUAL "")
12-
message(FATAL_ERROR "Non-empty value for argument: '${VAR_NAME}'")
12+
message(FATAL_ERROR "Non-empty value for argument: '${_REQUIRED_ARG}'")
1313
endif()
1414
endforeach()
1515
endmacro()

src/ystdlib/io_interface/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ if(TARGET ystdlib::io_interface)
22
return()
33
endif()
44

5-
if(NOT wrapped_facade_headers IN_LIST ystdlib_LIBRARIES)
5+
if(NOT "wrapped_facade_headers" IN_LIST ystdlib_LIBRARIES)
66
add_subdirectory(
77
"${CMAKE_CURRENT_LIST_DIR}/../wrapped_facade_headers"
88
"${CMAKE_CURRENT_BINARY_DIR}/implicit_dep/wrapped_facade_headers"

0 commit comments

Comments
 (0)