fix(cmake): Change include_guards from the global scope to the current scope, to enable find_package calls from different scopes to succeed (fixes #74).#75
Merged
Conversation
…ackage calls from different scopes to succeed.
WalkthroughAll four CMake config templates in cmake/ystdlib/libs switched include_guard(GLOBAL) to include_guard(). Other includes remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
include_guards from the global scope to the current scope, to enable find_package calls from different scopes to succeed (fixes #74).include_guards from the global scope to the current scope, to enable find_package calls from different scopes to succeed (fixes #74).
gibber9809
approved these changes
Sep 25, 2025
gibber9809
left a comment
There was a problem hiding this comment.
LGTM. I also previously tested that this change fixes things for the approach taken by this CLP PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the install scripts from
include_guard(GLOBAL)toinclude_guard(). TheGLOBALflag unnecessarily applies the guard to an entire project callingfind_package. Without the flag, ystdlib can be found and used in multiple independent scopes successfully.Checklist
breaking change.
Validation performed
Summary by CodeRabbit