Add query tag for http_request_total#8
Open
nutsoriginal wants to merge 1 commit into
Open
Conversation
Member
|
Hey, thanks for the pull request. One thing that bother me here is that query value can have very high and practically unlimited number of possible values, and monitoring systems doesn't like high cardinality time series (for an example see Prometheus' docs for metric labels). So it can be a bit dangerous. @dsalahutdinov, can you recall any details on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that README.md has example of
http_request_totalwith query tagBut actual code does not have this tag