Skip to content

Add query tag for http_request_total#8

Open
nutsoriginal wants to merge 1 commit into
yabeda-rb:masterfrom
nutsoriginal:add_query_tag
Open

Add query tag for http_request_total#8
nutsoriginal wants to merge 1 commit into
yabeda-rb:masterfrom
nutsoriginal:add_query_tag

Conversation

@nutsoriginal
Copy link
Copy Markdown

I found that README.md has example of http_request_total with query tag

http_request_total{host="dev.to",port="443",method="GET",query="/amplifr"} 145.0

But actual code does not have this tag

@Envek
Copy link
Copy Markdown
Member

Envek commented Jul 12, 2023

Hey, thanks for the pull request.

One thing that bother me here is that query value can have very high and practically unlimited number of possible values, and monitoring systems doesn't like high cardinality time series (for an example see Prometheus' docs for metric labels). So it can be a bit dangerous.

@dsalahutdinov, can you recall any details on query tag absense from implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants