Closed
Conversation
- Added TelegramBot class to handle Telegram Bot API interactions. - Implemented message processing, event emitting, and regex matching for text messages. - Introduced methods for starting/stopping polling and opening/closing webhooks. - Added support for file uploads with proper formatting and handling. - Included error handling for API requests and response parsing. chore: add TypeScript configuration files - Created tsconfig.json for TypeScript compiler options. - Added tsconfig.build.json for build-specific configurations.
- Moved TelegramBot and related utilities to src directory. - Updated import paths in examples and tests accordingly. - Added TypeScript definitions and source maps for examples and tests. - Replaced deprecated request-promise with node-fetch in tests and examples. - Enhanced test coverage for TelegramBot methods. - Updated build scripts to accommodate new directory structure. - Added utility functions for testing purposes.
yagop
reviewed
Oct 12, 2025
- Deleted test files: telegram.test.d.ts, telegram.test.d.ts.map, telegram.test.js, test.format-send-data.js, utils.d.ts, and utils.js. - Updated tsconfig.build.json to exclude test files from the build process.
…and TypeScript configurations
Co-authored-by: el-j <2795534+el-j@users.noreply.github.com>
Co-authored-by: el-j <2795534+el-j@users.noreply.github.com>
* Remove TODO comments and implement missing functionality Co-authored-by: el-j <2795534+el-j@users.noreply.github.com>
|
This PR appears to remove @cypress/request and @cypress/request-promise -- it would be excellent if it's possible to merge. It would resolve a vulnerable dependency for me. |
|
+1, please merge |
Author
|
now new following mr here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr moves to typescript, works with node20+ and has no vulnerabilities in build dependencies.