Commit 1f535e3
Restore AR 5.x/6.x compatibility in default_timezone and spec_helper
Commit 3d84e73 migrated default_timezone to the module-level
ActiveRecord.default_timezone API, which only exists on AR 7.0+.
Commit a37d58a then added a CI matrix covering AR 5.0-6.1, exposing
two latent failures:
- AR 5.0/5.1/5.2 raise NoMethodError on ActiveRecord.default_timezone=
- AR 6.0/6.1 fail to load active_record with
"uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger"
because logger is not required before active_support.
Version-gate the default_timezone accessor in both lib/plsql/schema.rb
and spec/plsql/schema_spec.rb via ActiveRecord.respond_to?, and require
"logger" before "active_record" in spec/spec_helper.rb.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent acef9de commit 1f535e3
3 files changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
| 104 | + | |
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
213 | | - | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
214 | 218 | | |
215 | 219 | | |
216 | 220 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
0 commit comments