Commit 2ab022d
Drop hardcoded DATABASE_VERSION from database_version spec
The "should get database version" spec compared PLSQL::Connection
#database_version against a DATABASE_VERSION env var set in each
workflow. The value was brittle: the test.yml / test_gemfiles.yml
rows hardcoded "23.26.1.0" (the Instant Client version), which
couples the spec to a manually maintained string that has to track
whichever gvenzl/oracle-free container is currently in use.
Drop the env var dependency and assert the structural shape instead
(an Array of four Integers) so the spec remains meaningful across
Oracle Database releases without a hardcoded version to maintain.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 8363f52 commit 2ab022d
5 files changed
Lines changed: 4 additions & 14 deletions
File tree
- .github/workflows
- spec
- plsql
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
426 | | - | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
427 | 429 | | |
428 | 430 | | |
429 | 431 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 56 | | |
60 | 57 | | |
61 | 58 | | |
62 | 59 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | 60 | | |
70 | 61 | | |
71 | 62 | | |
| |||
0 commit comments