Namespace ORACLE_DRIVER under PLSQL::JDBCConnection

Move the ORACLE_DRIVER constant and the DriverManager.registerDriver
call inside class PLSQL::JDBCConnection so the driver instance is no
longer defined as a top-level Ruby constant. This avoids polluting the
global namespace of the host application.

Update spec_helper.rb to reference the constant via its fully qualified
name PLSQL::JDBCConnection::ORACLE_DRIVER.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: yahonda

lib/plsql/jdbc_connection.rb

@@ -35,21 +35,25 @@
     end
   end
 
-  ORACLE_DRIVER = Java::oracle.jdbc.OracleDriver.new
-  java.sql.DriverManager.registerDriver ORACLE_DRIVER
-
   # set tns_admin property from TNS_ADMIN environment variable
   if !java.lang.System.get_property("oracle.net.tns_admin") && ENV["TNS_ADMIN"]
     java.lang.System.set_property("oracle.net.tns_admin", ENV["TNS_ADMIN"])
   end
 
-rescue LoadError, NameError
+rescue LoadError
   # JDBC driver is unavailable.
   raise LoadError, "ERROR: ruby-plsql could not load Oracle JDBC driver. Please install #{ojdbc_jars.empty? ? "Oracle JDBC" : ojdbc_jars.join(' or ') } library."
 end
 
 module PLSQL
   class JDBCConnection < Connection  # :nodoc:
+    begin
+      ORACLE_DRIVER = Java::oracle.jdbc.OracleDriver.new
+      java.sql.DriverManager.registerDriver ORACLE_DRIVER
+    rescue NameError
+      raise LoadError, "ERROR: ruby-plsql could not load Oracle JDBC driver."
+    end
+
     def self.create_raw(params)
       url = jdbc_connection_url(params)
       conn = begin

spec/spec_helper.rb

@@ -95,7 +95,7 @@ def get_connection(user_number = 0)
         # bypass DriverManager to work in cases where ojdbc*.jar
         # is added to the load path at runtime and not on the
         # system classpath
-        ORACLE_DRIVER.connect(get_connection_url, java.util.Properties.new.tap do |props|
+        PLSQL::JDBCConnection::ORACLE_DRIVER.connect(get_connection_url, java.util.Properties.new.tap do |props|
           props.setProperty("user", database_user)
           props.setProperty("password", database_password)
         end)