Always write debug.log during spec runs

Match the activerecord-oracle_enhanced-adapter convention of writing
spec SQL to debug.log unconditionally. The previous PLSQL_DEBUG_LOG
env var gate is removed so debug.log is always available when tests
fail, and debug.log is added to .gitignore.

Author: yahonda

.gitignore

@@ -8,6 +8,7 @@ pkg
 log
 tmp
 sqlnet.log
+debug.log
 Gemfile.lock
 *.zip
 .idea

spec/support/sql_logger.rb

@@ -1,35 +1,33 @@
-# Enable with: PLSQL_DEBUG_LOG=debug.log bundle exec rspec
+# Always write SQL executed during the spec run to debug.log.
 # Logger args mirror activerecord-oracle_enhanced-adapter's spec logger
 # (shift_age, shift_size) so debug.log behaves the same way.
-if (log_path = ENV["PLSQL_DEBUG_LOG"]) && !log_path.empty?
-  require "logger"
+require "logger"
 
-  PLSQL_DEBUG_LOGGER = Logger.new(log_path, 0, 100 * 1024 * 1024)
-  PLSQL_DEBUG_LOGGER.formatter = ->(_sev, time, _prog, msg) {
-    "#{time.iso8601(6)}  #{msg}\n"
-  }
+PLSQL_DEBUG_LOGGER = Logger.new("debug.log", 0, 100 * 1024 * 1024)
+PLSQL_DEBUG_LOGGER.formatter = ->(_sev, time, _prog, msg) {
+  "#{time.iso8601(6)}  #{msg}\n"
+}
 
-  module PLSQLSQLLogger
-    def exec(sql, *bindvars)
-      PLSQL_DEBUG_LOGGER.info("EXEC   #{sql.strip}#{bindvars.empty? ? '' : "  BINDS=#{bindvars.inspect}"}")
-      super
-    end
+module PLSQLSQLLogger
+  def exec(sql, *bindvars)
+    PLSQL_DEBUG_LOGGER.info("EXEC   #{sql.strip}#{bindvars.empty? ? '' : "  BINDS=#{bindvars.inspect}"}")
+    super
+  end
 
-    def cursor_from_query(sql, bindvars = [], options = {})
-      PLSQL_DEBUG_LOGGER.info("QUERY  #{sql.strip}#{bindvars.empty? ? '' : "  BINDS=#{bindvars.inspect}"}")
-      super
-    end
+  def cursor_from_query(sql, bindvars = [], options = {})
+    PLSQL_DEBUG_LOGGER.info("QUERY  #{sql.strip}#{bindvars.empty? ? '' : "  BINDS=#{bindvars.inspect}"}")
+    super
+  end
 
-    def parse(sql)
-      PLSQL_DEBUG_LOGGER.info("PARSE  #{sql.strip}")
-      super
-    end
+  def parse(sql)
+    PLSQL_DEBUG_LOGGER.info("PARSE  #{sql.strip}")
+    super
   end
+end
 
-  PLSQL::OCIConnection.prepend(PLSQLSQLLogger)  if defined?(PLSQL::OCIConnection)
-  PLSQL::JDBCConnection.prepend(PLSQLSQLLogger) if defined?(PLSQL::JDBCConnection)
+PLSQL::OCIConnection.prepend(PLSQLSQLLogger)  if defined?(PLSQL::OCIConnection)
+PLSQL::JDBCConnection.prepend(PLSQLSQLLogger) if defined?(PLSQL::JDBCConnection)
 
-  if defined?(ActiveRecord::Base)
-    ActiveRecord::Base.logger = PLSQL_DEBUG_LOGGER
-  end
+if defined?(ActiveRecord::Base)
+  ActiveRecord::Base.logger = PLSQL_DEBUG_LOGGER
 end