Skip to content

Commit c962f6c

Browse files
yahondaclaude
andcommitted
Remove Vagrant-based Oracle XE setup
The Vagrant workflow is superseded by the .devcontainer/ setup added in rsim#276, which boots gvenzl/oracle-free in a container and provisions the same hr and arunit accounts the spec suite expects via the existing ci/setup_accounts.sh. Maintaining both paths is unnecessary; the Vagrant configuration also targets a CentOS 7.2 box and the Oracle XE 11.2.0 RPM, which is no longer readily distributable. Removed: - Vagrantfile - spec/support/file_check_script.sh — only invoked by the Vagrantfile to verify the Oracle XE installer was placed in the project root - spec/support/test_db.rb — only invoked under USE_VM_DATABASE=Y and hardcoded to the XE service, system/oracle credentials, and the /u01/app/oracle/oradata/XE paths inside the Vagrant box - USE_VM_DATABASE branches in spec/spec_helper.rb - .vagrant entry from .gitignore - Vagrant sections from README.md TESTS instructions History.txt entries that mention the Vagrant box are left as historical changelog records. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 916c7ba commit c962f6c

6 files changed

Lines changed: 2 additions & 223 deletions

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@ tmp
1010
sqlnet.log
1111
Gemfile.lock
1212
*.zip
13-
.vagrant
1413
.idea
1514
spec/support/custom_config.rb

README.md

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,7 @@ Review `spec/spec_helper.rb` to see default schema/user names and database names
184184

185185
##### Prepare database
186186

187-
* With local [Vagrant](https://www.vagrantup.com) based Oracle XE database.
188-
189-
Download Oracle XE database ```oracle-xe-11.2.0-1.0.x86_64.rpm.zip``` from [Oracle Home page](http://www.oracle.com/technetwork/database/database-technologies/express-edition/downloads/index.html) and put it into project home directory.
190-
191-
From project home directory run ```vagrant up``` command to build fully functioning **Centos 6.6** virtual machine with installed Oracle XE database.
192-
193-
* Within other Oracle Database create Oracle database schema for test purposes.
187+
In an Oracle Database create the following schemas for test purposes.
194188

195189
SQL> CREATE USER hr IDENTIFIED BY hr;
196190
SQL> GRANT unlimited tablespace, create session, create table, create sequence, create procedure, create type, create view, create synonym TO hr;
@@ -210,12 +204,6 @@ Review `spec/spec_helper.rb` to see default schema/user names and database names
210204

211205
##### Run tests
212206

213-
* Run tests with local Vagrant based Oracle XE database
214-
215-
USE_VM_DATABASE=Y rake spec
216-
217-
* Run tests with other Oracle database
218-
219207
rake spec
220208

221209
LINKS

Vagrantfile

Lines changed: 0 additions & 38 deletions
This file was deleted.

spec/spec_helper.rb

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,14 @@
3939
# in spec/support/ and its subdirectories.
4040
Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each { |f| require f }
4141

42-
if ENV["USE_VM_DATABASE"] == "Y"
43-
DATABASE_NAME = "XE"
44-
else
45-
DATABASE_NAME = ENV["DATABASE_NAME"] || "orcl"
46-
end
47-
42+
DATABASE_NAME = ENV["DATABASE_NAME"] || "orcl"
4843
DATABASE_SERVICE_NAME = ENV["DATABASE_SERVICE_NAME"] || DATABASE_NAME
4944
DATABASE_HOST = ENV["DATABASE_HOST"] || "localhost"
5045
DATABASE_PORT = (ENV["DATABASE_PORT"] || 1521).to_i
5146
DATABASE_USERS_AND_PASSWORDS = [
5247
[ENV["DATABASE_USER"] || "hr", ENV["DATABASE_PASSWORD"] || "hr"],
5348
[ENV["DATABASE_USER2"] || "arunit", ENV["DATABASE_PASSWORD2"] || "arunit"]
5449
]
55-
if ENV["USE_VM_DATABASE"] == "Y"
56-
RSpec.configure do |config|
57-
config.before(:suite) do
58-
TestDb.build
59-
end
60-
end
61-
end
6250

6351
def oracle_error_class
6452
unless defined?(JRUBY_VERSION)

spec/support/file_check_script.sh

Lines changed: 0 additions & 9 deletions
This file was deleted.

spec/support/test_db.rb

Lines changed: 0 additions & 149 deletions
This file was deleted.

0 commit comments

Comments
 (0)