Update submodule(voicevox_core 0.16.4対応)#264
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the voicevox_core submodule to version 0.16.4 and adds comprehensive singing synthesis capabilities to VoicevoxCoreSharp. The update introduces new validation APIs for musical data, frame-based singing synthesis methods, and corresponding error codes to improve robustness and enable advanced singing features.
Changes:
- Added four new error codes for validating Score, Note, FrameAudioQuery, and FramePhoneme data types
- Implemented validation methods for musical data structures and compatibility checking between scores and audio queries
- Introduced frame-based singing synthesis APIs for creating queries, generating f0/volume data, and synthesizing audio
- Updated documentation for memory management functions to reference new singing synthesis methods
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/VoicevoxCoreSharp.Core.Tests/SynthesizerTest.cs | Added comprehensive test for singing synthesis workflow |
| src/VoicevoxCoreSharp.Experimental/SynthesizerExtensions.cs | Added async extension methods for new singing synthesis APIs |
| src/VoicevoxCoreSharp.Core/VoicevoxCoreSharp.Core.Metas.props | Updated voicevox_core commit hash to new version |
| src/VoicevoxCoreSharp.Core/Utils.cs | Added validation methods for Score, Note, FrameAudioQuery, FramePhoneme, and compatibility checking |
| src/VoicevoxCoreSharp.Core/Synthesizer.cs | Implemented frame-based singing synthesis methods and refactored TtsFromKana indentation |
| src/VoicevoxCoreSharp.Core/Native/CoreUnsafe.g.cs | Added native P/Invoke declarations for validation and singing synthesis APIs, updated documentation |
| src/VoicevoxCoreSharp.Core/Enum/ResultCode.cs | Added four new error code enum values and mapping logic |
| src/VoicevoxCoreSharp.Core.Unity/Runtime/Script/Utils.cs | Unity version of validation methods for musical data types |
| src/VoicevoxCoreSharp.Core.Unity/Runtime/Script/Synthesizer.cs | Unity version of singing synthesis methods and TtsFromKana refactoring |
| src/VoicevoxCoreSharp.Core.Unity/Runtime/Script/Native/CoreUnsafe.g.cs | Unity version of native API declarations and documentation updates |
| src/VoicevoxCoreSharp.Core.Unity/Runtime/Script/Enum/ResultCode.cs | Unity version of new error codes and mappings |
| binding/voicevox_core | Updated submodule to cbb5ef8e292fc63d22e23e19dca521b48c1a950c |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the singing synthesis functionality and error handling in the VoicevoxCoreSharp Unity bindings. The main changes include adding new error codes, validation APIs for musical data types, and new methods for frame-based singing synthesis. These updates improve robustness and expand the API to support more advanced singing features.
Singing synthesis and musical data validation enhancements
CoreUnsafe.g.csfor validatingScore,Note,FrameAudioQuery, andFramePhonemeJSON inputs, as well as for checking compatibility between musical score and audio query data. This improves error detection and data integrity for singing synthesis workflows.Error code and result handling improvements
RESULT_INVALID_SCORE_ERROR,RESULT_INVALID_NOTE_ERROR,RESULT_INVALID_FRAME_AUDIO_QUERY_ERROR,RESULT_INVALID_FRAME_PHONEME_ERROR) to theResultCodeenum and mapped them in conversion methods, allowing for more precise error reporting for invalid musical data. [1] [2] [3] [4]Documentation and memory management updates
Submodule update
voicevox_coresubmodule to a newer commit, likely to support the new singing and validation features.These changes collectively strengthen the singing synthesis capabilities and error handling in the Unity bindings, making the library more robust and feature-rich for musical applications.