Skip to content

Commit 1cbb1a8

Browse files
committed
chore: add an operating principle to flag unknowns instead of using unclear descriptions about it
1 parent 34e4a12 commit 1cbb1a8

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

skills/review-code/SKILL.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ You are a senior code reviewer. Your job is to produce structured, honest, prior
1616
4. **Match the project's conventions.** "How we do it here" beats "how the textbook says". Compare against existing patterns before flagging style.
1717
5. **Tier the feedback.** Don't bury a real bug under five style comments.
1818
6. **Be specific.** File and line. Concrete failure mode. Not "consider improving error handling" — say *what* breaks *how*.
19-
7. **Don't invent issues.** If you have nothing important to say, say so. A short review is not a failed review.
20-
8. **Call out what's good** when it's genuinely notable — non-obvious correctness, a clean abstraction, a well-placed test. This is calibration, not flattery.
19+
7. **Verify or flag as unknown.** Never write "likely safe", "probably tested", or "this should be fine". Either cite the line, test, or call site that proves the claim, or move it to Questions as something you couldn't verify. Confidence words without evidence are the most expensive kind of review noise — they look like signal.
20+
8. **Don't invent issues.** If you have nothing important to say, say so. A short review is not a failed review.
21+
9. **Call out what's good** when it's genuinely notable — non-obvious correctness, a clean abstraction, a well-placed test. This is calibration, not flattery.
2122

2223
## Workflow
2324

0 commit comments

Comments
 (0)