Skip to content

Commit 62c5de2

Browse files
committed
Advance deprecation cycle for MDB aliases/aliases_dict
1 parent 36e8dcc commit 62c5de2

3 files changed

Lines changed: 11 additions & 26 deletions

File tree

yamcs-client/src/yamcs/mdb/model.py

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import abc
2-
import warnings
32
from typing import Dict, List, Optional, Tuple
43

54
from yamcs.protobuf.mdb import mdb_pb2
@@ -31,32 +30,19 @@ def qualified_name(self) -> str:
3130
return self._proto.qualifiedName
3231

3332
@property
34-
def aliases(self) -> List[Tuple[str, str]]:
35-
"""
36-
List of (namespace, name) pairs, as 2-tuples
37-
38-
.. deprecated:: 1.9.2
39-
Use :attr:`aliases_dict` instead, which returns a dictionary instead of
40-
a list of 2-tuples.
41-
42-
In a future release, the ``aliases`` property will be changed to match the
43-
return type of :attr:`aliases_dict`.
44-
"""
45-
warnings.warn(
46-
"Use 'aliases_dict' instead of 'aliases'. This returns "
47-
"a dictionary instead of a list of 2-tuples. In a future release, "
48-
"the 'aliases' property will be changed to match the return type "
49-
"of 'aliases_dict'.",
50-
category=FutureWarning,
51-
)
52-
return list(
53-
{alias.namespace: alias.name for alias in self._proto.alias}.items()
54-
)
33+
def aliases(self) -> Dict[str, str]:
34+
"""Aliases, keyed by namespace"""
35+
return {alias.namespace: alias.name for alias in self._proto.alias}
5536

5637
@property
5738
def aliases_dict(self) -> Dict[str, str]:
58-
"""Aliases, keyed by namespace"""
59-
return {alias.namespace: alias.name for alias in self._proto.alias}
39+
"""
40+
Aliases, keyed by namespace
41+
42+
This method shall be deprecated in a future release. Use
43+
:attr:`aliases` instead.
44+
"""
45+
return self.aliases
6046

6147
@property
6248
def description(self) -> Optional[str]:

yamcs-client/src/yamcs/model.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from yamcs.core.helpers import parse_server_time
55
from yamcs.protobuf.events import events_pb2
66
from yamcs.protobuf.instances import instances_pb2
7-
from yamcs.protobuf.links import links_pb2
87
from yamcs.protobuf.services import services_pb2
98

109

yamcs-client/src/yamcs/storage/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def create_bucket(self, bucket_name: str):
9292
"""
9393
req = buckets_pb2.CreateBucketRequest()
9494
req.name = bucket_name
95-
url = f"/storage/buckets"
95+
url = "/storage/buckets"
9696
self.ctx.post_proto(url, data=req.SerializeToString())
9797

9898
def remove_bucket(self, bucket_name: str):

0 commit comments

Comments
 (0)