Remove sdls_get_stats

Based on feedback, it does not currently provide any benefits.

Author: Alex Balgavy

yamcs-client/src/yamcs/client/links/client.py

@@ -1,11 +1,11 @@
 import functools
-from typing import Any, Callable, Dict, Iterable, Mapping, Optional
+from typing import Any, Callable, Dict, Mapping, Optional
 
 from google.protobuf import json_format, struct_pb2
 from yamcs.client.core.context import Context
 from yamcs.client.core.futures import WebSocketSubscriptionFuture
 from yamcs.client.core.subscriptions import WebSocketSubscriptionManager
-from yamcs.client.links.model import Cop1Config, Cop1Status, SdlsStats
+from yamcs.client.links.model import Cop1Config, Cop1Status
 from yamcs.client.model import Link
 from yamcs.protobuf.cop1 import cop1_pb2
 from yamcs.protobuf.links import links_pb2
@@ -232,9 +232,7 @@ def get_cop1_status(self) -> Cop1Status:
         message.ParseFromString(response.content)
         return Cop1Status(message)
 
-    def create_cop1_subscription(
-        self, on_data: Callable[[Cop1Status], None], timeout: float = 60
-    ) -> Cop1Subscription:
+    def create_cop1_subscription(self, on_data: Callable[[Cop1Status], None], timeout: float = 60) -> Cop1Subscription:
         """
         Create a new subscription for receiving status of the COP1 link.
 
@@ -258,9 +256,7 @@ def create_cop1_subscription(
         # Represent subscription as a future
         subscription = Cop1Subscription(manager)
 
-        wrapped_callback = functools.partial(
-            _wrap_callback_parse_cop1_status, subscription, on_data
-        )
+        wrapped_callback = functools.partial(_wrap_callback_parse_cop1_status, subscription, on_data)
 
         manager.open(wrapped_callback)
 
@@ -284,23 +280,6 @@ def sdls_reset_ctr(self, spi: int):
         """
         self.ctx.delete_proto(f"/sdls/{self._instance}/{self._link}/{spi}/seq")
 
-    def sdls_get_stats(self) -> Iterable[SdlsStats]:
-        """
-        Get statistics for all `spi`s (Security Parameter Indices) on this link.
-        """
-        response = self.ctx.get_proto(f"/sdls/{self._instance}/stats")
-        message = sdls_pb2.GetStatsResponse()
-        message.ParseFromString(response.content)
-        stats = getattr(message, "stats")
-        link_stats = []
-
-        for stat in stats:
-            parsed_stat = SdlsStats(stat)
-            if parsed_stat.link_name == self._link:
-                link_stats.append(parsed_stat)
-
-        return iter(link_stats)
-
     def sdls_set_key(self, spi: int, key: bytes):
         """
         Update the `key` associated with a given `spi` (Security Parameter Index) on this link.

yamcs-client/src/yamcs/client/links/model.py

@@ -87,24 +87,3 @@ def __str__(self):
         res = f"VC_ID: {self.vc_id}, win: {self.window_width}"
         res += f", timeout_type: {self.timeout_type}"
         return res + f", tx_limit: {self.tx_limit}, t1: {self.t1}"
-
-
-class SdlsStats:
-    def __init__(self, proto):
-        self._proto = proto
-
-    @property
-    def instance(self) -> str:
-        return self._proto.instance
-
-    @property
-    def link_name(self) -> str:
-        return self._proto.linkName
-
-    @property
-    def spi(self) -> int:
-        return self._proto.spi
-
-    @property
-    def seq(self) -> int:
-        return self._proto.seqCtr