Skip to content

fix(scim-users): use SCIM filter path when updating email #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yamitzky merged 1 commit into from
Apr 22, 2026
Merged

fix(scim-users): use SCIM filter path when updating email #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/scim-users/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export async function executeScimUsersUpdate(

if (opts.active !== undefined) operations.push({ op: "replace", path: "active", value: opts.active });
if (opts.userName !== undefined) operations.push({ op: "replace", path: "userName", value: opts.userName });
if (opts.email !== undefined) operations.push({ op: "replace", path: "emails", value: [{ value: opts.email, primary: true }] });
if (opts.email !== undefined) operations.push({ op: "replace", path: 'emails[primary eq true].value', value: opts.email });
if (opts.givenName !== undefined) operations.push({ op: "replace", path: "name.givenName", value: opts.givenName });
if (opts.familyName !== undefined) operations.push({ op: "replace", path: "name.familyName", value: opts.familyName });
if (opts.displayName !== undefined) operations.push({ op: "replace", path: "displayName", value: opts.displayName });
Expand Down
10 changes: 10 additions & 0 deletions tests/commands/scim-users/update.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ describe("scim-users update", () => {
]);
});

test("updates email using SCIM filter path for primary address", async () => {
const updated = { id: "U001", emails: [{ value: "new@example.com", primary: true }] };
const mockUpdate = mock(() => Promise.resolve(updated));
const client = { users: { update: mockUpdate } } as any;
await executeScimUsersUpdate(client, { id: "U001", email: "new@example.com" });
expect(mockUpdate).toHaveBeenCalledWith("U001", [
{ op: "replace", path: 'emails[primary eq true].value', value: "new@example.com" },
]);
});

test("throws when no fields provided", async () => {
const client = { users: { update: mock(() => Promise.resolve({})) } } as any;
await expect(executeScimUsersUpdate(client, { id: "U001" })).rejects.toThrow(
Expand Down
Loading