Покрытие класса BooksCollector тестами#32
Open
MariyaUll wants to merge 6 commits into
Open
Conversation
Comment on lines
+32
to
+35
| @pytest.mark.parametrize('book_name', [ | ||
| '', # тест с пустой строкой — книга не должна быть добавлена | ||
| 'a' * 41 # тест со строкой из 41 символа (превышает лимит в 40 символов) — книга не должна быть добавлена | ||
| ]) |
There was a problem hiding this comment.
Необходимо исправить: не хватает позитивных тестов на проверку имени книги
Collaborator
Author
There was a problem hiding this comment.
Добавлена проверка на добавление книги с валидным названием
Comment on lines
+71
to
+72
| if book_name != 'Неизвестная книга': # добавляем книгу, если она не «Неизвестная книга» | ||
| collector.add_new_book(book_name) |
There was a problem hiding this comment.
Нужно исправить: использование условных блоков в теле теста лишает их атомарности. Можно попробовать, например, расширить количество параметров или их переработать дабы избежать этой ситуации. Если не получается объединить их все, то отдельные можно разместить отдельно исключив из параметризации
Collaborator
Author
There was a problem hiding this comment.
Разделила проверку на два теста
Comment on lines
+161
to
+162
| collector.add_book_in_favorites(book_name) | ||
| collector.add_book_in_favorites(book_name) # повторная попытка добавления |
There was a problem hiding this comment.
Можно лучше: стоит еще добавить тест на повторное добавление книги в коллекцию
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.