Skip to content

feat: support fetch favicon from origin URL #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fatpandac wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

feat: support fetch favicon from origin URL #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/scripts/models/source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export const enum SourceTextDirection {
export class RSSSource {
sid: number
url: string
originUrl?: string
iconurl?: string
name: string
openTarget: SourceOpenTarget
Expand All @@ -60,6 +61,7 @@ export class RSSSource {

static async fetchMetaData(source: RSSSource) {
let feed = await parseRSS(source.url)
source.originUrl = feed.link
if (!source.name) {
if (feed.title) source.name = feed.title.trim()
source.name = source.name || intl.get("sources.untitled")
Expand Down Expand Up @@ -426,8 +428,8 @@ export function updateFavicon(
sids = sids.filter(sid => sid in initSources)
}
const promises = sids.map(async sid => {
const url = initSources[sid].url
let favicon = (await fetchFavicon(url)) || ""
const { originUrl, url }= initSources[sid]
let favicon = (await fetchFavicon(originUrl || url)) || ""
const source = getState().sources[sid]
if (
source &&
Expand Down