Skip to content

feat: add language and keyword filtering options #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinethonazam-droid wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add language and keyword filtering options #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions good_first_issues/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
"""Entrypoint of the CLI"""
import argparse

Copy link
Copy Markdown

@iamteamstar iamteamstar Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the argparse implementation. The --language and --keyword arguments should be implemented using @click.option() inside search.py where the actual search command is defined

parser = argparse.ArgumentParser()
parser.add_argument("--language", help="Filter by programming language")
parser.add_argument("--keyword", help="Filter by keyword in title or description")

import click
from rich.console import Console

from good_first_issues.commands import (
config,
rate_limit,
search,
search, # THIS IS ALREADY THE COMMAND
Copy link
Copy Markdown

@iamteamstar iamteamstar Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this inline comment

show_version as version,
)

console = Console(color_system="auto")


@click.group()
def cli():
"""
Get good first issues to start hacking.

(Requires GitHub Authentication Token)

$ gfi search

"""
pass
Copy link
Copy Markdown

@iamteamstar iamteamstar Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this inline comment as well before we merge



cli.add_command(config)
cli.add_command(search)
cli.add_command(search) # <-- command already implemented in search.py
cli.add_command(rate_limit)
cli.add_command(version)
cli.add_command(version)