Skip to content

fix: set-once-freeze for PKG_NATIVE_CACHE_PATH resolution #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olegcS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: set-once-freeze for PKG_NATIVE_CACHE_PATH resolution #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions prelude/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2187,8 +2187,22 @@ function payloadFileSync(pointer) {
// - Windows: C:\Users\John\.cache
// Custom example: /opt/myapp/cache or C:\myapp\cache
// Native addons will be extracted to: <PKG_NATIVE_CACHE_BASE>/pkg/<hash>
const PKG_NATIVE_CACHE_BASE =
//
// The cache path is resolved lazily on the first dlopen call and then frozen.
// This gives the application a window to set process.env.PKG_NATIVE_CACHE_PATH
// in its init code (before any native addon is loaded) without requiring it to
// be set before the process starts. Once resolved, the value cannot change.
const PKG_NATIVE_CACHE_DEFAULT =
process.env.PKG_NATIVE_CACHE_PATH || path.join(homedir(), '.cache');
let PKG_NATIVE_CACHE_BASE = null;

function getNativeCacheBase() {
if (PKG_NATIVE_CACHE_BASE === null) {
PKG_NATIVE_CACHE_BASE =
process.env.PKG_NATIVE_CACHE_PATH || PKG_NATIVE_CACHE_DEFAULT;
}
return PKG_NATIVE_CACHE_BASE;
}

function revertMakingLong(f) {
if (/^\\\\\?\\/.test(f)) return f.slice(4);
Expand All @@ -2209,7 +2223,7 @@ function payloadFileSync(pointer) {
// the hash is needed to be sure we reload the module in case it changes
const hash = createHash('sha256').update(moduleContent).digest('hex');

const tmpFolder = path.join(PKG_NATIVE_CACHE_BASE, 'pkg', hash);
const tmpFolder = path.join(getNativeCacheBase(), 'pkg', hash);

fs.mkdirSync(tmpFolder, { recursive: true });

Expand Down