Refactor file download error handling#7
Open
sweep-ai-deprecated[bot] wants to merge 4 commits into
Open
Conversation
sweep-ai-deprecated
Bot
added
the
sweep
Owner
|
Also refactor this commit: sweep: 1f17aa9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the error handling in the file download process to provide a more robust and flexible error handling mechanism.
Summary of Changes
dl.go:DlTomethod of theGHReleaseDlstruct with an error return. This ensures that errors during the file download process are returned to the caller function instead of abruptly stopping the program execution.ghdl/main.go:Runfunction of therootCmdvariable to handle the error returned by theDlTomethod. If an error is returned, an error message is printed and the program exits with a non-zero status code.These changes improve the code's reliability and maintainability by providing a more controlled and predictable error handling mechanism.
Fixes #3.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.