test: add regression for non-count option with value 1#534
Closed
ZhouYinLong-lab wants to merge 1 commit into
Closed
test: add regression for non-count option with value 1#534ZhouYinLong-lab wants to merge 1 commit into
ZhouYinLong-lab wants to merge 1 commit into
Conversation
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a regression test for non-count options that receive a value of
1.Why
When passing
-x 3 -x 1, the parser incorrectly treats the1as a count increment, returningx: 4instead ofx: [3, 1]. The root cause is insetKey()wherevalue === increment()(which is1) gates the increment logic, incorrectly matching actual values of1.Verification
The test currently fails as expected.
Related issue
Refs #506