Fix vscode settings generated by @yarnpkg/sdks#7116
Open
brandonbothell wants to merge 6 commits intoyarnpkg:masterfrom
Open
Fix vscode settings generated by @yarnpkg/sdks#7116brandonbothell wants to merge 6 commits intoyarnpkg:masterfrom
brandonbothell wants to merge 6 commits intoyarnpkg:masterfrom
Conversation
Contributor
Author
|
Edit: Release Strategy added; PR ready for review. Original: I still need to check compatibility with Linux/macOS systems before converting this from a draft, at which point I will add a release strategy. |
10057d5 to
70f40c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Adds VSCode version detection to
@yarnpkg/sdksto ensure proper settings. See https://code.visualstudio.com/updates/v1_110#_unified-javascript-and-typescript-settingsCloses #7107
How did you fix it?
code --versioncommand (orcode.cmd --versionon Windows) to check the version and parse it, just like we do for node in@yarnpkg/pnp.Checklist