Skip to content

Fix vscode settings generated by @yarnpkg/sdks#7116

Open
brandonbothell wants to merge 6 commits intoyarnpkg:masterfrom
brandonbothell:fix-vscode-settings
Open

Fix vscode settings generated by @yarnpkg/sdks#7116
brandonbothell wants to merge 6 commits intoyarnpkg:masterfrom
brandonbothell:fix-vscode-settings

Conversation

@brandonbothell
Copy link
Copy Markdown
Contributor

What's the problem this PR addresses?

Adds VSCode version detection to @yarnpkg/sdks to ensure proper settings. See https://code.visualstudio.com/updates/v1_110#_unified-javascript-and-typescript-settings

Closes #7107

How did you fix it?

  • I used the code --version command (or code.cmd --version on Windows) to check the version and parse it, just like we do for node in @yarnpkg/pnp.
  • Then, if the version is compatible with the unified settings, use those and delete the old settings.
  • If we can't figure out the VSCode version for some reason, we just add both sets of settings just to be sure it will work without modification.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@brandonbothell
Copy link
Copy Markdown
Contributor Author

brandonbothell commented Apr 23, 2026

Edit: Release Strategy added; PR ready for review.

Original: I still need to check compatibility with Linux/macOS systems before converting this from a draft, at which point I will add a release strategy.

@brandonbothell brandonbothell changed the title Fix vscode settings Fix vscode settings generated by @yarnpkg/sdks Apr 23, 2026
@brandonbothell brandonbothell marked this pull request as ready for review April 23, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] VSCode settings TSDK

1 participant