Angular.js-based management portal for Geofencing#3
Open
antonba wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Can you change to use the versions of the libs from the CDNs?
Owner
There was a problem hiding this comment.
Agreee... it makes it very hard to review the diff.
Author
There was a problem hiding this comment.
The template I used came with a different bootstrap file; also I may have modified it too; what's the issue? the portal is self-contained...
Contributor
There was a problem hiding this comment.
It is a lot of extra code that is not strictly necessary. I got it to (mostly) work with no local 3rd party files, using the CDN ones:
<link rel="stylesheet" href="//netdna.bootstrapcdn.com/bootstrap/2.3.2/css/bootstrap.min.css">
<script src='https://whatsnear.azure-mobile.net/client/MobileServices.Web-1.0.0.min.js'></script>
<script src='https://ajax.aspnetcdn.com/ajax/jQuery/jquery-2.0.3.min.js'></script>
<script src="//netdna.bootstrapcdn.com/bootstrap/2.3.2/js/bootstrap.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.0.7/angular.min.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.0.7/angular-resource.min.js"></script>
Contributor
|
Remove the Starbucks-Cut.txt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check that there isn't additional stuff to the portal because I see commits to Geofencing/Data/Starbucks.txt and Geofencing/Data/Starbucks - cut.txt that I haven't made.