finish the app#3
Open
garak wants to merge 1 commit into
Open
Conversation
yceruto
reviewed
Sep 9, 2022
| $this->createdAt = new DateTimeImmutable(); | ||
| } | ||
|
|
||
| public function update( |
Owner
There was a problem hiding this comment.
$blogPost->update(content: 'new content');vs
$blogPost->changeContent('new content');[SRP] It looks simple but in my opinion, is not a good thing when your logic starts growing or you have to do something specific for each value (like domain validations).
| { | ||
| $blogPost = $this->useCase->execute($id, $author, $title, $content); | ||
|
|
||
| if ('json' === $format) { |
Owner
There was a problem hiding this comment.
[OCP] This is open for modification. An extension mechanism would be needed to avoid modifying this class each time a new format is added.
| { | ||
| $blogPosts = $this->useCase->execute(); | ||
|
|
||
| if ('json' === $format) { |
Owner
There was a problem hiding this comment.
[OCP] same here, this is open for modification and can be avoided by creating a dedicated class or method to do this job without asking for the format here, e.g.:
$this->renderer->renderCollection($blogPosts);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.