Skip to content

issue-1541: process only read-only handles asynchronously during close#6375

Merged
WilyTiger merged 3 commits into
mainfrom
users/wilytiger/issue-1541-2
Jul 13, 2026
Merged

issue-1541: process only read-only handles asynchronously during close#6375
WilyTiger merged 3 commits into
mainfrom
users/wilytiger/issue-1541-2

Conversation

@WilyTiger

@WilyTiger WilyTiger commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Notes

We want to enable async destroy only for files opened read-only, as a safer option

Issue

#1541

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 261s): all tests PASSED for commit 09c267f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
964 964 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 260s): all tests PASSED for commit 09c267f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1184 1184 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1305s): all tests PASSED for commit 09c267f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6571 6570 0 0 0 1 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4417s): all tests PASSED for commit 09c267f.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3875 3875 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

@WilyTiger
WilyTiger force-pushed the users/wilytiger/issue-1541-2 branch from 30c31af to f0bb8ab Compare July 9, 2026 15:02
@WilyTiger WilyTiger changed the title issue-1541: add flag to process only read only handles asynchronously issue-1541: process only read-only handles asynchronously during close Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

  • ✅ tasks + storage
  • ✅ blockstore
  • ✅ disk + manager
  • ✅ filestore

@WilyTiger WilyTiger added filestore Add this label to run only cloud/filestore build and tests on PR asan Launch builds with address sanitizer along with regular build tsan Launch builds with thread sanitizer along with regular build msan Launch builds with memory sanitizer along with regular build ubsan Launch builds with undefined behaviour sanitizer along with regular build labels Jul 9, 2026
@WilyTiger
WilyTiger marked this pull request as ready for review July 9, 2026 15:07
@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5055s): all tests PASSED for commit f0bb8ab.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4140 4140 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-msan have completed.

Tip

Planned checks for linux-x86_64-release-msan.

🔴 linux-x86_64-release-msan target: cloud/filestore/ (test time: 3730s): some tests FAILED for commit f0bb8ab.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3530 3529 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🔴 linux-x86_64-release-tsan target: cloud/filestore/ (test time: 3959s): some tests FAILED for commit f0bb8ab.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3541 3540 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-asan have completed.

Tip

Planned checks for linux-x86_64-release-asan.

🔴 linux-x86_64-release-asan target: cloud/filestore/ (test time: 3782s): some tests FAILED for commit f0bb8ab.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3551 3550 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-ubsan have completed.

Tip

Planned checks for linux-x86_64-release-ubsan.

🔴 linux-x86_64-release-ubsan target: cloud/filestore/ (test time: 3585s): some tests FAILED for commit f0bb8ab.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3601 3599 0 2 0 0 0

SvartMetal
SvartMetal reviewed Jul 9, 2026
View reviewed changes
Comment thread cloud/filestore/libs/vfs_fuse/fs_impl_data.cpp
SvartMetal
SvartMetal reviewed Jul 9, 2026
View reviewed changes
Comment thread cloud/filestore/libs/vfs_fuse/fs_impl.cpp Outdated
@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-msan have completed.

Tip

Planned checks for linux-x86_64-release-msan.

🔴 linux-x86_64-release-msan target: cloud/filestore/ (test time: 3580s): some tests FAILED for commit 0dc473c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3530 3529 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🔴 linux-x86_64-release-tsan target: cloud/filestore/ (test time: 3966s): some tests FAILED for commit 0dc473c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3541 3539 0 2 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5107s): all tests PASSED for commit 0dc473c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4140 4140 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-ubsan have completed.

Tip

Planned checks for linux-x86_64-release-ubsan.

🔴 linux-x86_64-release-ubsan target: cloud/filestore/ (test time: 3537s): some tests FAILED for commit 0dc473c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3601 3600 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-asan have completed.

Tip

Planned checks for linux-x86_64-release-asan.

🔴 linux-x86_64-release-asan target: cloud/filestore/ (test time: 3693s): some tests FAILED for commit 0dc473c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3551 3550 0 1 0 0 0

@WilyTiger
WilyTiger force-pushed the users/wilytiger/issue-1541-2 branch from 0dc473c to f520192 Compare July 10, 2026 09:07
@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🔴 linux-x86_64-release-tsan target: cloud/filestore/ (test time: 4284s): some tests FAILED for commit f520192.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3548 3547 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5038s): all tests PASSED for commit f520192.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4147 4147 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-msan have completed.

Tip

Planned checks for linux-x86_64-release-msan.

🟢 linux-x86_64-release-msan target: cloud/filestore/ (test time: 3742s): all tests PASSED for commit f520192.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3537 3537 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-asan have completed.

Tip

Planned checks for linux-x86_64-release-asan.

🟢 linux-x86_64-release-asan target: cloud/filestore/ (test time: 3744s): all tests PASSED for commit f520192.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3558 3558 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-ubsan have completed.

Tip

Planned checks for linux-x86_64-release-ubsan.

🟢 linux-x86_64-release-ubsan target: cloud/filestore/ (test time: 3549s): all tests PASSED for commit f520192.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3608 3608 0 0 0 0 0

@WilyTiger
WilyTiger force-pushed the users/wilytiger/issue-1541-2 branch from f520192 to bf1465c Compare July 10, 2026 15:55
@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-ubsan have completed.

Tip

Planned checks for linux-x86_64-release-ubsan.

🔴 linux-x86_64-release-ubsan target: cloud/filestore/ (test time: 3531s): some tests FAILED for commit bf1465c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3608 3606 0 2 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-msan have completed.

Tip

Planned checks for linux-x86_64-release-msan.

🟢 linux-x86_64-release-msan target: cloud/filestore/ (test time: 3663s): all tests PASSED for commit bf1465c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3537 3537 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4971s): all tests PASSED for commit bf1465c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4147 4147 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-asan have completed.

Tip

Planned checks for linux-x86_64-release-asan.

🟢 linux-x86_64-release-asan target: cloud/filestore/ (test time: 3710s): all tests PASSED for commit bf1465c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3558 3558 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🟢 linux-x86_64-release-tsan target: cloud/filestore/ (test time: 4255s): all tests PASSED for commit bf1465c.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3548 3548 0 0 0 0 0

SvartMetal
SvartMetal previously approved these changes Jul 10, 2026
View reviewed changes
qkrorlqr
qkrorlqr reviewed Jul 10, 2026
View reviewed changes
Comment thread cloud/filestore/libs/vfs_fuse/fs_impl_data.cpp
qkrorlqr
qkrorlqr previously approved these changes Jul 10, 2026
View reviewed changes
@WilyTiger
WilyTiger dismissed stale reviews from qkrorlqr and SvartMetal via d8bf4d2 July 13, 2026 11:45
@WilyTiger
WilyTiger force-pushed the users/wilytiger/issue-1541-2 branch from bf1465c to d8bf4d2 Compare July 13, 2026 11:45
@github-actions

github-actions Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-asan have completed.

Tip

Planned checks for linux-x86_64-release-asan.

🔴 linux-x86_64-release-asan target: cloud/filestore/ (test time: 3684s): some tests FAILED for commit d8bf4d2.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3565 3564 0 1 0 0 0

@github-actions

github-actions Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-msan have completed.

Tip

Planned checks for linux-x86_64-release-msan.

🟢 linux-x86_64-release-msan target: cloud/filestore/ (test time: 3655s): all tests PASSED for commit d8bf4d2.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3544 3544 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-ubsan have completed.

Tip

Planned checks for linux-x86_64-release-ubsan.

🟢 linux-x86_64-release-ubsan target: cloud/filestore/ (test time: 3473s): all tests PASSED for commit d8bf4d2.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3615 3615 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4713s): all tests PASSED for commit d8bf4d2.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4154 4154 0 0 0 0 0

@github-actions

github-actions Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-release-tsan have completed.

Tip

Planned checks for linux-x86_64-release-tsan.

🟢 linux-x86_64-release-tsan target: cloud/filestore/ (test time: 3834s): all tests PASSED for commit d8bf4d2.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3555 3555 0 0 0 0 0

@WilyTiger
WilyTiger merged commit 4d7c88b into main Jul 13, 2026
47 of 51 checks passed
@WilyTiger
WilyTiger deleted the users/wilytiger/issue-1541-2 branch July 13, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qkrorlqr qkrorlqr qkrorlqr left review comments
@e673 e673 e673 left review comments
@SvartMetal SvartMetal SvartMetal approved these changes
@agalibin agalibin agalibin approved these changes

Assignees

No one assigned

Labels

asan Launch builds with address sanitizer along with regular build filestore Add this label to run only cloud/filestore build and tests on PR msan Launch builds with memory sanitizer along with regular build tsan Launch builds with thread sanitizer along with regular build ubsan Launch builds with undefined behaviour sanitizer along with regular build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WilyTiger @qkrorlqr @SvartMetal @e673 @agalibin